Skip to content

Commit 1746573

Browse files
committed
testssl gives up on a hung handshake instead of the whole run
testssl stopped at its 15 minute limit on 18 of the latest scans, and kept no TLS result at all. A handshake that never answers held it until then. Each connection now gives up on its own: 15 seconds to connect and 20 for OpenSSL, so one slow cipher check costs seconds, not the run.
1 parent 3b63b06 commit 1746573

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎app/core/dast_engines.py‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,12 @@ def command(tool: str, url: str, host: str, profile: str, workdir: Path,
208208
exe = binary(tool)
209209
if tool == "testssl":
210210
report = workdir / "testssl.json"
211+
# A handshake that never answers used to hold testssl until the 15
212+
# minute limit, and no TLS result was kept at all. Each connection
213+
# now gives up on its own: 15 seconds to connect, 20 for OpenSSL.
211214
return ([exe, "--jsonfile", str(report), "--quiet", "--color", "0",
212-
"--warnings", "off", "--user-agent", _ua(), host], report)
215+
"--warnings", "off", "--connect-timeout", "15",
216+
"--openssl-timeout", "20", "--user-agent", _ua(), host], report)
213217
if tool == "nuclei":
214218
tags = {"quick": "exposure,misconfig,cve,default-login",
215219
"thorough": "exposure,misconfig,cve,default-login,token-spray,"

0 commit comments

Comments
 (0)