From 14bb06ff41a9154f657f61740eb16456189adc7e Mon Sep 17 00:00:00 2001 From: feywind <57276408+feywind@users.noreply.github.com> Date: Wed, 16 Sep 2026 21:34:38 +0000 Subject: [PATCH 1/2] fix: fix several docs generation issues --- core/dev-packages/jsdoc-region-tag/src/index.js | 7 ++++--- handwritten/firestore/package.json | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/core/dev-packages/jsdoc-region-tag/src/index.js b/core/dev-packages/jsdoc-region-tag/src/index.js index 35c2ab1cd318..7cc9c3ff1bcc 100644 --- a/core/dev-packages/jsdoc-region-tag/src/index.js +++ b/core/dev-packages/jsdoc-region-tag/src/index.js @@ -25,9 +25,10 @@ const REGION_END_REGEX = /\[END/; const sampleCache = new Map(); exports.loadSampleCache = function () { - const sampleCandidates = glob.sync(`${SAMPLES_DIRECTORY}/**/*.{js,ts}`, { - ignore: ['node_modules'], - }); + const sampleCandidates = [ + ...glob.sync(`${SAMPLES_DIRECTORY}/**/*.js`, {ignore: ['node_modules']}), + ...glob.sync(`${SAMPLES_DIRECTORY}/**/*.ts`, {ignore: ['node_modules']}), + ]; for (const candidate of sampleCandidates) { const stat = statSync(candidate); if (!stat.isFile()) continue; diff --git a/handwritten/firestore/package.json b/handwritten/firestore/package.json index a2361ef21e36..d24ae20b0ddc 100644 --- a/handwritten/firestore/package.json +++ b/handwritten/firestore/package.json @@ -120,7 +120,7 @@ "//_comment": "TODO: Remove @sinonjs/fake-timers overrides/resolutions when version > 15.3.0 fixes the duplicate identifier 'withGlobal' issue.", "overrides": { "@sinonjs/fake-timers": "15.1.1", - "brace-expansion": "^2.0.1" + "brace-expansion": "5.0.7" }, "exports": { ".": { From f73f1f1cc79d707b66fdc5db0b0c2db5a888f680 Mon Sep 17 00:00:00 2001 From: feywind <57276408+feywind@users.noreply.github.com> Date: Wed, 16 Sep 2026 21:49:38 +0000 Subject: [PATCH 2/2] chore: trying CR suggestion --- core/dev-packages/jsdoc-region-tag/src/index.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/dev-packages/jsdoc-region-tag/src/index.js b/core/dev-packages/jsdoc-region-tag/src/index.js index 7cc9c3ff1bcc..35c2ab1cd318 100644 --- a/core/dev-packages/jsdoc-region-tag/src/index.js +++ b/core/dev-packages/jsdoc-region-tag/src/index.js @@ -25,10 +25,9 @@ const REGION_END_REGEX = /\[END/; const sampleCache = new Map(); exports.loadSampleCache = function () { - const sampleCandidates = [ - ...glob.sync(`${SAMPLES_DIRECTORY}/**/*.js`, {ignore: ['node_modules']}), - ...glob.sync(`${SAMPLES_DIRECTORY}/**/*.ts`, {ignore: ['node_modules']}), - ]; + const sampleCandidates = glob.sync(`${SAMPLES_DIRECTORY}/**/*.{js,ts}`, { + ignore: ['node_modules'], + }); for (const candidate of sampleCandidates) { const stat = statSync(candidate); if (!stat.isFile()) continue;