Stacks should have auto-merge capability #239
Replies: 7 comments 3 replies
|
I want this too. Or else we will need to handle the stress with trying to merge it before the base branch gets updated again. |
|
Yeah, this is kind of a dealbreaker for us for use within github.com. Love the CLI though! |
|
Thanks for the feedback! We will be re-introducing the auto-merge option for stacks in a future update. The reason it's not there is that we had to create an entirely new merge path for stacks (especially in order to merge multiple PRs at once), so there's a number of features like auto-merge or admin bypass that we need to re-implement to get stack merges to parity with regular PRs. |
|
Yeah we're currently ditching the feature until it is better supported. |
|
A useful auto-merge semantic would be to merge the longest contiguous ready prefix from the bottom of the stack. As each bottom-up layer satisfies its checks, reviews, and branch protections, GitHub could merge it automatically, then rebase/retarget the remaining layers and continue until it reaches the first unready layer. Higher layers would remain open. This preserves dependency order while allowing reviewed foundational changes to land unattended without requiring the entire stack to become ready atomically. In our first stack, we had to disable an already-enabled auto-merge on the bottom PR just to link it, which made adopting stacks a regression for this workflow. |
|
Yes, this is definitely essential to my team. Please let's bump the priority on this, it's a non brainer productivity gain. |
|
yes! And I would argue that auto-merge the entire stack when ready is a more useful feature than individual PRs within the stack (as merging individual PRs within the stack causes excessive CI churn as each one is rebased as the lower PRs merge individually - generally 99% of the time you want the entire stack to merge, so prioritizing the full stack auto-merge is far more useful IMO). If I had my druthers, each PR could be set to "Merge stack up to here when ready" which could be selectively toggled (but beggars can't be choosers). Just this one function would provide all the varied usage paths (set on all PRs to have each merge individually, or selectively set at the top of each chunk of PRs that you want to merge as a set, or just the top PR to only merge when all PRs are ready). |
Uh oh!
There was an error while loading. Please reload this page.
I'm not seeing any way in the UI to enable automerge for a PR in a stack, or for the stack as a whole. This would be very helpful!
All reactions