Skip to content

Commit 126c292

Browse files
committed
Fix Micronaut inline test expectations
1 parent 9d164d0 commit 126c292

8 files changed

Lines changed: 144 additions & 144 deletions

File tree

java/ql/test/library-tests/dataflow/taintsources/MicronautConfig.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,21 @@ private static void sink(Object o) {}
1515

1616
@Get("/secret")
1717
void testValueField() {
18-
sink(secretValue); // $hasLocalValueFlow
18+
sink(secretValue); // $ hasLocalValueFlow
1919
}
2020

2121
@Get("/key")
2222
void testPropertyField() {
23-
sink(apiKey); // $hasLocalValueFlow
23+
sink(apiKey); // $ hasLocalValueFlow
2424
}
2525

2626
@Get("/param")
2727
void testPropertyParam(@Property(name = "app.api-key") String appName) {
28-
sink(appName); // $hasLocalValueFlow
28+
sink(appName); // $ hasLocalValueFlow
2929
}
3030

3131
@Get("/param")
3232
void testValueParam(@Value("${app.name}") String appName) {
33-
sink(appName); // $hasLocalValueFlow
33+
sink(appName); // $ hasLocalValueFlow
3434
}
3535
}

java/ql/test/library-tests/frameworks/micronaut/MicronautControllerTest.java

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -12,76 +12,76 @@ void sink(Object o) {}
1212

1313
@Get("/path/{id}")
1414
void testPathVariable(@PathVariable String id) {
15-
sink(id); // $hasTaintFlow
15+
sink(id); // $ hasTaintFlow
1616
}
1717

1818
@Get("/query")
1919
void testQueryValue(@QueryValue String name) {
20-
sink(name); // $hasTaintFlow
20+
sink(name); // $ hasTaintFlow
2121
}
2222

2323
@Post("/body")
2424
void testBody(@Body String body) {
25-
sink(body); // $hasTaintFlow
25+
sink(body); // $ hasTaintFlow
2626
}
2727

2828
@Get("/header")
2929
void testHeader(@Header String authorization) {
30-
sink(authorization); // $hasTaintFlow
30+
sink(authorization); // $ hasTaintFlow
3131
}
3232

3333
@Get("/cookie")
3434
void testCookieValue(@CookieValue String sessionId) {
35-
sink(sessionId); // $hasTaintFlow
35+
sink(sessionId); // $ hasTaintFlow
3636
}
3737

3838
@Post("/part")
3939
void testPart(@Part String name) {
40-
sink(name); // $hasTaintFlow
40+
sink(name); // $ hasTaintFlow
4141
}
4242

4343
@Get("/attr")
4444
void testRequestAttribute(@RequestAttribute String attr) {
45-
sink(attr); // $hasTaintFlow
45+
sink(attr); // $ hasTaintFlow
4646
}
4747

4848
@Post("/bean")
4949
void testRequestBean(@RequestBean Object bean) {
50-
sink(bean); // $hasTaintFlow
50+
sink(bean); // $ hasTaintFlow
5151
}
5252

5353
@Get("/implicit")
5454
void testImplicitParam(String implicitParam) {
55-
sink(implicitParam); // $hasTaintFlow
55+
sink(implicitParam); // $ hasTaintFlow
5656
}
5757

5858
@Get("/request")
5959
void testHttpRequest(HttpRequest<String> request) {
60-
sink(request); // $hasTaintFlow
60+
sink(request); // $ hasTaintFlow
6161
}
6262

6363
@Get("/headers")
6464
void testHttpHeaders(HttpHeaders headers) {
65-
sink(headers); // $hasTaintFlow
65+
sink(headers); // $ hasTaintFlow
6666
}
6767

6868
@Get("/parameters")
6969
void testHttpParameters(HttpParameters parameters) {
70-
sink(parameters); // $hasTaintFlow
70+
sink(parameters); // $ hasTaintFlow
7171
}
7272

7373
@Get("/cookies")
7474
void testCookies(Cookies cookies) {
75-
sink(cookies); // $hasTaintFlow
76-
sink(cookies.getValue("session")); // $hasTaintFlow
75+
sink(cookies); // $ hasTaintFlow
76+
sink(cookies.getValue("session")); // $ hasTaintFlow
7777
for (java.util.Map.Entry<String, Cookie> entry : cookies) {
78-
sink(entry.getValue()); // $hasTaintFlow
78+
sink(entry.getValue()); // $ hasTaintFlow
7979
}
8080
}
8181

8282
@Post("/stream")
8383
void testInputStream(@Body InputStream stream) {
84-
sink(stream); // $hasTaintFlow
84+
sink(stream); // $ hasTaintFlow
8585
}
8686

8787
@Post("/reader")
@@ -91,39 +91,39 @@ void testReader(Reader reader) {
9191

9292
@Post("/post")
9393
void testPostMethod(@Body String data) {
94-
sink(data); // $hasTaintFlow
94+
sink(data); // $ hasTaintFlow
9595
}
9696

9797
@Put("/put")
9898
void testPutMethod(@Body String data) {
99-
sink(data); // $hasTaintFlow
99+
sink(data); // $ hasTaintFlow
100100
}
101101

102102
@Delete("/delete/{id}")
103103
void testDeleteMethod(@PathVariable String id) {
104-
sink(id); // $hasTaintFlow
104+
sink(id); // $ hasTaintFlow
105105
}
106106

107107
@Patch("/patch")
108108
void testPatchMethod(@Body String data) {
109-
sink(data); // $hasTaintFlow
109+
sink(data); // $ hasTaintFlow
110110
}
111111

112112
@io.micronaut.http.annotation.Error
113113
void testErrorHandler(HttpRequest<?> request) {
114-
sink(request); // $hasTaintFlow
114+
sink(request); // $ hasTaintFlow
115115
}
116116

117117
@io.micronaut.http.annotation.Error
118118
void testAnnotatedErrorHandler(@Header String header, @RequestBean Object bean) {
119-
sink(header); // $hasTaintFlow
120-
sink(bean); // $hasTaintFlow
119+
sink(header); // $ hasTaintFlow
120+
sink(bean); // $ hasTaintFlow
121121
}
122122

123123
@io.micronaut.http.annotation.Error
124124
void testErrorHandlerCarriers(HttpHeaders headers, HttpParameters parameters, Cookies cookies) {
125-
sink(headers); // $hasTaintFlow
126-
sink(parameters); // $hasTaintFlow
127-
sink(cookies); // $hasTaintFlow
125+
sink(headers); // $ hasTaintFlow
126+
sink(parameters); // $ hasTaintFlow
127+
sink(cookies); // $ hasTaintFlow
128128
}
129129
}

java/ql/test/library-tests/frameworks/micronaut/MicronautFileUploadTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ void sink(Object o) {}
99

1010
@Post("/file")
1111
void testFileUpload(CompletedFileUpload file) throws IOException {
12-
sink(file.getFilename()); // $hasTaintFlow
13-
sink(file.getBytes()); // $hasTaintFlow
14-
sink(file.getInputStream()); // $hasTaintFlow
15-
sink(file.getContentType()); // $hasTaintFlow
16-
sink(file.getSize()); // $hasTaintFlow
12+
sink(file.getFilename()); // $ hasTaintFlow
13+
sink(file.getBytes()); // $ hasTaintFlow
14+
sink(file.getInputStream()); // $ hasTaintFlow
15+
sink(file.getContentType()); // $ hasTaintFlow
16+
sink(file.getSize()); // $ hasTaintFlow
1717
}
1818
}

0 commit comments

Comments
 (0)