From 315cbaac5c49ea99f33875d77cd7ad332c3955aa Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Fri, 28 Aug 2026 16:35:49 -0400 Subject: [PATCH 1/2] Update skills_lint to published version ^0.5.1 - Update tool/pubspec.yaml to depend on published skills_lint: ^0.5.1 - Remove TODO comment referencing issue #9771 - Update pubspec.lock Closes https://github.com/flutter/devtools/issues/9771 --- pubspec.lock | 13 ++++++------- tool/pubspec.yaml | 7 +------ 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/pubspec.lock b/pubspec.lock index 72b7d242fe6..91ef2950433 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -752,11 +752,10 @@ packages: skills_lint: dependency: transitive description: - path: "packages/skills_lint" - ref: e6e695e1550f81342fe5acd4dbe65040b5aa44c3 - resolved-ref: e6e695e1550f81342fe5acd4dbe65040b5aa44c3 - url: "https://github.com/google/skills_lint.dart.git" - source: git + name: skills_lint + sha256: "5daeff89c8c9d812cfa811e119ae88a32bb81d28c73aa7e899155885b2e63a63" + url: "https://pub.dev" + source: hosted version: "0.5.1" sky_engine: dependency: transitive @@ -975,10 +974,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "0016aef94fc66495ac78af5859181e3f3bf2026bd8eecc72b9565601e19ab360" + sha256: "5f37239c4851efcef929cea7824e76df7f2f0970aef85d66bbc430afa40e72f0" url: "https://pub.dev" source: hosted - version: "15.2.0" + version: "15.3.0" vm_service_protos: dependency: transitive description: diff --git a/tool/pubspec.yaml b/tool/pubspec.yaml index 37053adf369..ae200a8b2c5 100644 --- a/tool/pubspec.yaml +++ b/tool/pubspec.yaml @@ -24,10 +24,5 @@ dependencies: dev_dependencies: logging: ^1.1.1 - # TODO(https://github.com/flutter/devtools/issues/9771): Update to published version - skills_lint: - git: - url: https://github.com/google/skills_lint.dart.git - path: packages/skills_lint - ref: e6e695e1550f81342fe5acd4dbe65040b5aa44c3 + skills_lint: ^0.5.1 test: ^1.25.8 From e61044e7d0dbcc27d446e77a3d63423b98dc3002 Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Fri, 28 Aug 2026 17:19:52 -0400 Subject: [PATCH 2/2] Add @visibleForTesting to NetworkRequest.durationDisplay to fix DCM --- packages/devtools_app/lib/src/screens/network/network_model.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/devtools_app/lib/src/screens/network/network_model.dart b/packages/devtools_app/lib/src/screens/network/network_model.dart index f1011061993..76af3a9f6ad 100644 --- a/packages/devtools_app/lib/src/screens/network/network_model.dart +++ b/packages/devtools_app/lib/src/screens/network/network_model.dart @@ -41,6 +41,7 @@ abstract class NetworkRequest String get id; + @visibleForTesting String get durationDisplay { final duration = this.duration; final text = duration != null