diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index aad4b036b4..47c68509d4 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -23,4 +23,4 @@ jobs: strategy: matrix: - gcc: [10, 11] + gcc: [10, 11, 14] diff --git a/lib/op-attrs/include/op-attrs/parallel_dim.h b/lib/op-attrs/include/op-attrs/parallel_dim.h index a12951dec9..ec56dd4f26 100644 --- a/lib/op-attrs/include/op-attrs/parallel_dim.h +++ b/lib/op-attrs/include/op-attrs/parallel_dim.h @@ -2,6 +2,7 @@ #define _FLEXFLOW_OP_ATTRS_INCLUDE_OP_ATTRS_PARALLEL_DIM_H #include "op-attrs/parallel_dim.dtg.h" +#include "utils/positive_int/positive_int.h" namespace FlexFlow { @@ -11,7 +12,7 @@ bool is_replica_dim(ParallelDim const &); ParallelDim with_size_set_to(ParallelDim const &, size_t); ParallelDim with_degree_set_to(ParallelDim const &, int); ParallelDim with_is_replica_set_to(ParallelDim const &, bool); -int get_degree(ParallelDim const &); +positive_int get_degree(ParallelDim const &); } // namespace FlexFlow diff --git a/lib/op-attrs/src/op-attrs/parallel_dim.cc b/lib/op-attrs/src/op-attrs/parallel_dim.cc index 26ba2b3fa1..116d72e5be 100644 --- a/lib/op-attrs/src/op-attrs/parallel_dim.cc +++ b/lib/op-attrs/src/op-attrs/parallel_dim.cc @@ -3,8 +3,8 @@ namespace FlexFlow { -int get_degree(ParallelDim const &dim) { - return dim.visit(overload{ +positive_int get_degree(ParallelDim const &dim) { + return dim.visit(overload{ [](ShardParallelDim const &shard_dim) { return shard_dim.degree; }, [](ReplicaParallelDim const &replica_dim) { return replica_dim.degree; diff --git a/lib/utils/include/utils/containers/filter.h b/lib/utils/include/utils/containers/filter.h index 85a413c2c7..1b39dec2cd 100644 --- a/lib/utils/include/utils/containers/filter.h +++ b/lib/utils/include/utils/containers/filter.h @@ -4,6 +4,7 @@ #include #include #include +#include #include #include diff --git a/lib/utils/include/utils/containers/inplace_filter.h b/lib/utils/include/utils/containers/inplace_filter.h index dc0491773f..2e696613ec 100644 --- a/lib/utils/include/utils/containers/inplace_filter.h +++ b/lib/utils/include/utils/containers/inplace_filter.h @@ -3,6 +3,9 @@ #include "utils/containers/filter.h" #include +#include +#include +#include #include #include diff --git a/lib/utils/include/utils/containers/unordered_set_of.h b/lib/utils/include/utils/containers/unordered_set_of.h index 5a8dcd9f55..011ecb515d 100644 --- a/lib/utils/include/utils/containers/unordered_set_of.h +++ b/lib/utils/include/utils/containers/unordered_set_of.h @@ -9,7 +9,7 @@ namespace FlexFlow { template std::unordered_set unordered_set_of(C const &c) { - return std::unordered_set{c.cbegin(), c.cend()}; + return std::unordered_set{c.cbegin(), c.cend()}; } template