refactor: rename three mis-scoped translation units

Each file's name described only a fraction of its contents. Rename to
match what they actually hold (pure file renames + reference updates;
no behavior change). Build green, full suite 109/109.

  webserver_finalize.cpp -> webserver_hook_firing.cpp
    Holds only the four gated hook-firing helpers (before_handler,
    after_handler, response_sent, request_completed). finalize_answer
    itself lives in webserver_request.cpp.

  webserver_setup.cpp -> webserver_lifecycle.cpp
    Holds MHD option building AND start/stop/run/quiesce/get_fdset/
    add_connection, the IP ACL setters, and the server info getters --
    the daemon lifecycle surface, not just setup.

  http_utils_inet.hpp -> http_utils_helpers.hpp
    Holds the free-function helper overflow from http_utils.hpp: only
    get_ip_str/get_port are inet; the rest are dump_header_map/
    dump_arg_map/http_unescape/load_file/base_unescaper.

specs/ planning archive still references the old filenames; left as-is
(dated historical records, out of scope for the code readability pass).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: etr

src/Makefile.am

@@ -25,12 +25,12 @@ lib_LTLIBRARIES = libhttpserver.la
 # builds. The WS-off branch in websocket_handler.cpp provides stub
 # definitions (every member throws feature_unavailable except is_valid()
 # which returns false).
-libhttpserver_la_SOURCES = string_utilities.cpp webserver.cpp webserver_add_hook.cpp http_utils.cpp file_info.cpp http_request.cpp http_request_auth.cpp http_response.cpp http_response_factories.cpp http_resource.cpp create_webserver.cpp create_test_request.cpp websocket_handler.cpp hook_handle.cpp peer_address.cpp resource_hook_table.cpp cookie.cpp detail/http_endpoint.cpp detail/body.cpp detail/ip_representation.cpp detail/http_request_impl.cpp detail/http_request_impl_args.cpp detail/http_request_impl_tls.cpp detail/webserver_setup.cpp detail/webserver_register.cpp detail/webserver_routes.cpp detail/webserver_routes_upsert.cpp detail/webserver_callbacks.cpp detail/webserver_callbacks_lifecycle.cpp detail/webserver_websocket.cpp detail/webserver_dispatch.cpp detail/webserver_request.cpp detail/webserver_response_queue.cpp detail/webserver_body_pipeline.cpp detail/webserver_error_pages.cpp detail/webserver_aliases.cpp detail/webserver_finalize.cpp detail/hook_phase_dispatch.cpp
+libhttpserver_la_SOURCES = string_utilities.cpp webserver.cpp webserver_add_hook.cpp http_utils.cpp file_info.cpp http_request.cpp http_request_auth.cpp http_response.cpp http_response_factories.cpp http_resource.cpp create_webserver.cpp create_test_request.cpp websocket_handler.cpp hook_handle.cpp peer_address.cpp resource_hook_table.cpp cookie.cpp detail/http_endpoint.cpp detail/body.cpp detail/ip_representation.cpp detail/http_request_impl.cpp detail/http_request_impl_args.cpp detail/http_request_impl_tls.cpp detail/webserver_lifecycle.cpp detail/webserver_register.cpp detail/webserver_routes.cpp detail/webserver_routes_upsert.cpp detail/webserver_callbacks.cpp detail/webserver_callbacks_lifecycle.cpp detail/webserver_websocket.cpp detail/webserver_dispatch.cpp detail/webserver_request.cpp detail/webserver_response_queue.cpp detail/webserver_body_pipeline.cpp detail/webserver_error_pages.cpp detail/webserver_aliases.cpp detail/webserver_hook_firing.cpp detail/hook_phase_dispatch.cpp
 # noinst_HEADERS: shipped in the tarball but NEVER installed under $prefix/include.
 # Detail headers (httpserver/detail/*.hpp) live here so they cannot leak to
 # downstream consumers — the public surface comes in through <httpserver.hpp>.
 noinst_HEADERS = httpserver/string_utilities.hpp httpserver/detail/modded_request.hpp httpserver/detail/http_endpoint.hpp httpserver/detail/body.hpp httpserver/detail/webserver_impl.hpp httpserver/detail/webserver_impl_dispatch.hpp httpserver/detail/connection_state.hpp httpserver/detail/secure_zero.hpp httpserver/detail/http_request_impl.hpp httpserver/detail/resource_hook_table.hpp httpserver/detail/route_entry.hpp httpserver/detail/lambda_resource.hpp httpserver/detail/segment_trie.hpp httpserver/detail/route_cache.hpp httpserver/detail/route_tier.hpp httpserver/detail/unescape_helpers.hpp gettext.h
-nobase_include_HEADERS = httpserver.hpp httpserver/body_kind.hpp httpserver/cookie.hpp httpserver/constants.hpp httpserver/create_webserver.hpp httpserver/create_webserver_setters.hpp httpserver/create_test_request.hpp httpserver/webserver.hpp httpserver/webserver_routes.hpp httpserver/webserver_runtime.hpp httpserver/webserver_websocket.hpp httpserver/webserver_hooks.hpp httpserver/websocket_handler.hpp httpserver/http_utils.hpp httpserver/http_utils_inet.hpp httpserver/ip_representation.hpp httpserver/file_info.hpp httpserver/http_request.hpp httpserver/http_request_auth.hpp httpserver/http_request_getters.hpp httpserver/http_response.hpp httpserver/http_response_factories.hpp httpserver/http_resource.hpp httpserver/feature_unavailable.hpp httpserver/iovec_entry.hpp httpserver/http_arg_value.hpp httpserver/http_method.hpp httpserver/hook_phase.hpp httpserver/hook_action.hpp httpserver/hook_handle.hpp httpserver/hook_context.hpp
+nobase_include_HEADERS = httpserver.hpp httpserver/body_kind.hpp httpserver/cookie.hpp httpserver/constants.hpp httpserver/create_webserver.hpp httpserver/create_webserver_setters.hpp httpserver/create_test_request.hpp httpserver/webserver.hpp httpserver/webserver_routes.hpp httpserver/webserver_runtime.hpp httpserver/webserver_websocket.hpp httpserver/webserver_hooks.hpp httpserver/websocket_handler.hpp httpserver/http_utils.hpp httpserver/http_utils_helpers.hpp httpserver/ip_representation.hpp httpserver/file_info.hpp httpserver/http_request.hpp httpserver/http_request_auth.hpp httpserver/http_request_getters.hpp httpserver/http_response.hpp httpserver/http_response_factories.hpp httpserver/http_resource.hpp httpserver/feature_unavailable.hpp httpserver/iovec_entry.hpp httpserver/http_arg_value.hpp httpserver/http_method.hpp httpserver/hook_phase.hpp httpserver/hook_action.hpp httpserver/hook_handle.hpp httpserver/hook_context.hpp
 
 AM_CXXFLAGS += -fPIC -Wall
 

src/detail/hook_phase_dispatch.cpp

@@ -307,7 +307,7 @@ detail::webserver_impl::fire_handler_exception(
 //
 // after_handler is the post-handler short-circuit. Returns engaged
 // optional iff a hook short-circuited with respond_with(); the caller
-// (fire_after_handler_gated in webserver_finalize.cpp) emplaces the new
+// (fire_after_handler_gated in webserver_hook_firing.cpp) emplaces the new
 // response into mr->response ahead of materialize_and_queue_response.
 
 std::optional<::httpserver::http_response>

src/detail/ip_representation.cpp

@@ -362,7 +362,7 @@ bool is_v4_mapped_prefix_octet_pair(uint16_t a, uint16_t b) {
 // case does not apply are bytes 10-11 folded into the scores and the
 // totals compared.
 //
-// insert_wildcard_aware in src/detail/webserver_setup.cpp relies on
+// insert_wildcard_aware in src/detail/webserver_lifecycle.cpp relies on
 // this equivalence: std::set::find must locate a stored entry that
 // merely OVERLAPS the new one (wildcard-subsumed, or v4-mapped vs
 // plain form) so the more-permissive entry can win.

src/detail/webserver_callbacks_lifecycle.cpp

@@ -134,7 +134,7 @@ namespace detail {
 void webserver_impl::connection_notify(void* cls, struct MHD_Connection* connection,
                                        void** socket_context,
                                        enum MHD_ConnectionNotificationCode toe) {
-    // cls is the owning webserver* (set in webserver_setup.cpp at
+    // cls is the owning webserver* (set in webserver_lifecycle.cpp at
     // MHD_OPTION_NOTIFY_CONNECTION). It MAY be null in tests that
     // exercise the callback without an enclosing webserver; defensive
     // null-check gates every hook fire on a non-null impl.

src/detail/webserver_finalize.cpp src/detail/webserver_hook_firing.cppsrc/detail/webserver_finalize.cpp renamed to src/detail/webserver_hook_firing.cpp

@@ -18,10 +18,10 @@
      USA
 */
 
-// Gated hook-firing helpers for the after_handler, response_sent, and
-// request_completed lifecycle phases. Carved out of webserver_request.cpp
-// and webserver_callbacks.cpp to keep each TU under the project LOC
-// ceiling. See per-function comments for behavioral details.
+// Gated hook-firing helpers for the before_handler, after_handler,
+// response_sent, and request_completed lifecycle phases. Carved out of
+// webserver_request.cpp and webserver_callbacks.cpp to keep each TU under
+// the project LOC ceiling. See per-function comments for behavioral details.
 
 #include "httpserver/webserver.hpp"
 #include "httpserver/detail/webserver_impl.hpp"

src/detail/webserver_setup.cpp src/detail/webserver_lifecycle.cppsrc/detail/webserver_setup.cpp renamed to src/detail/webserver_lifecycle.cpp

@@ -330,7 +330,7 @@ void webserver::unregister_resource(const string& resource) {
 //   deny_ip / remove_denied_ip   -> the deny list (exception under ACCEPT)
 //   allow_ip / remove_allowed_ip -> the allow list (exception under REJECT;
 //                                   also overrides a deny entry under ACCEPT)
-// See webserver::deny_ip / allow_ip (impls in webserver_setup.cpp) and
+// See webserver::deny_ip / allow_ip (impls in webserver_lifecycle.cpp) and
 // classify_decision (webserver_callbacks_lifecycle.cpp).
 
 }  // namespace httpserver

src/detail/webserver_register.cpp

@@ -224,7 +224,7 @@ void fire_request_completed(
 
 // Gated-fire helpers, members so the http_response friendship
 // applies (response_sent_ctx::bytes_queued reads response.body_->size()).
-// Definitions live in src/detail/webserver_finalize.cpp.
+// Definitions live in src/detail/webserver_hook_firing.cpp.
 //
 // @p resource is the resolved resource borrowed from finalize_answer's
 // owning shared_ptr (nullptr on the 404 / short-circuit paths where no
@@ -248,7 +248,7 @@ void fire_request_completed_gated(modded_request* mr,
 // short-circuited (mr->response already populated; caller must go
 // straight to materialize_and_queue_response). False means both chains
 // passed (or both gates were closed) and dispatch should proceed.
-// Definition lives in src/detail/webserver_finalize.cpp alongside the
+// Definition lives in src/detail/webserver_hook_firing.cpp alongside the
 // other gated-fire helpers. @p hrm is the resolved resource (non-null at
 // the call site in finalize_answer).
 bool fire_before_handler_gated(

src/httpserver/detail/webserver_impl_dispatch.hpp

@@ -445,6 +445,6 @@ using arg_view_map = std::map<std::string_view, http_arg_value, http::arg_compar
 // consumers of <httpserver/http_utils.hpp> still see the type.
 #include "httpserver/ip_representation.hpp"
 
-#include "httpserver/http_utils_inet.hpp"
+#include "httpserver/http_utils_helpers.hpp"
 #endif  // SRC_HTTPSERVER_HTTP_UTILS_HPP_
 

src/httpserver/http_utils.hpp

@@ -22,7 +22,7 @@
 #error "Only <httpserver.hpp> or <httpserverpp> can be included directly."
 #endif
 
-// http_utils_inet.hpp -- free-function helpers in namespace
+// http_utils_helpers.hpp -- free-function helpers in namespace
 // httpserver::http (sockaddr -> string/port, header/arg map dumps, URL
 // unescape, file loading).
 //
@@ -32,8 +32,8 @@
 // after the types these declarations reference (header_view_map /
 // header_map / arg_view_map / unescaper_ptr) are defined; not intended to
 // be included on its own.
-#ifndef SRC_HTTPSERVER_HTTP_UTILS_INET_HPP_
-#define SRC_HTTPSERVER_HTTP_UTILS_INET_HPP_
+#ifndef SRC_HTTPSERVER_HTTP_UTILS_HELPERS_HPP_
+#define SRC_HTTPSERVER_HTTP_UTILS_HELPERS_HPP_
 
 #include <stddef.h>
 #include <stdint.h>
@@ -105,4 +105,4 @@ size_t base_unescaper(std::string*, unescaper_ptr unescaper);
 }  // namespace http
 }  // namespace httpserver
 
-#endif  // SRC_HTTPSERVER_HTTP_UTILS_INET_HPP_
+#endif  // SRC_HTTPSERVER_HTTP_UTILS_HELPERS_HPP_