diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e34eb78..b40ea04 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,7 +20,7 @@ jobs: - name: Set up Ruby 3.2 uses: ruby/setup-ruby@v1 with: - ruby-version: '3.2' + ruby-version: '3.4' - name: Build run: | bundler install diff --git a/.github/workflows/ruby-linters.yml b/.github/workflows/ruby-linters.yml index 361b685..82a8e37 100644 --- a/.github/workflows/ruby-linters.yml +++ b/.github/workflows/ruby-linters.yml @@ -22,7 +22,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.2' + ruby-version: '3.4' - name: Install Gems run: | bundler install diff --git a/lib/jay_api/elasticsearch/async.rb b/lib/jay_api/elasticsearch/async.rb index 07ae3a9..3ece3ef 100644 --- a/lib/jay_api/elasticsearch/async.rb +++ b/lib/jay_api/elasticsearch/async.rb @@ -40,7 +40,7 @@ def initialize(index) # failures def delete_by_query(query, slices: 5) Concurrent::Promise.execute do - async_response = index.delete_by_query(query, slices: slices, wait_for_completion: false) + async_response = index.delete_by_query(query, slices:, wait_for_completion: false) result = tasks.by_id(async_response[:task]) validate_result(result) result @@ -49,6 +49,14 @@ def delete_by_query(query, slices: 5) private + + + + + + + + # @param [Hash] result The operation result to be validated # @raise [Errors::QueryExecutionError] If executing the query results in # errors @@ -56,7 +64,6 @@ def delete_by_query(query, slices: 5) # failures def validate_result(result) raise Errors::QueryExecutionError, "Errors on index '#{index_name}':\n #{result[:error]}" if result[:error] - failures = result&.dig(:response, :failures) return if failures.nil? || failures.empty?