From 0815012d2cc71ef54eba49ee73ff1542396b44df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jukka=20Jyl=C3=A4nki?= Date: Sat, 15 Feb 2020 19:35:37 +0200 Subject: [PATCH] Fix bad buffer ID checks in AL.bufQueue JS object keys are always strings, testing if (bufId !== 0) would always yield true. --- src/library_openal.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/library_openal.js b/src/library_openal.js index 238ec863e24f0..4bda2959beba1 100644 --- a/src/library_openal.js +++ b/src/library_openal.js @@ -1450,7 +1450,7 @@ var LibraryOpenAL = { if (srcLen > 0.0) { var frequency; for (var bufId in src.bufQueue) { - if (bufId !== 0) { + if (bufId) { frequency = src.bufQueue[bufId].frequency; break; } @@ -1472,7 +1472,7 @@ var LibraryOpenAL = { if (srcLen > 0.0) { var bytesPerSec; for (var bufId in src.bufQueue) { - if (bufId !== 0) { + if (bufId) { var buf = src.bufQueue[bufId]; bytesPerSec = buf.frequency * buf.bytesPerSample * buf.channels; break;