CORE-798: fix pre-commit CI errors#1007
Conversation
- Update flake8 from 6.0.0 to 7.1.1 to fix false positives from pycodestyle 2.10.0 mishandling f-strings (E201/E202/E231/E272/E713) - Apply black/isort formatting to test_microbatch_compiled_code.py - Apply sqlfmt formatting to 2 SQL macro files - Apply prettier formatting to dbt_project.yml Co-Authored-By: Noy Arie <noyarie1992@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @NoyaArie |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis pull request applies formatting consistency improvements across test utilities and macro implementations, alongside dependency and configuration updates. The flake8 linter is upgraded and a dbt microbatch execution flag is explicitly enabled, while test helpers and macro code adopt multi-line formatting for improved readability. ChangesFormatting and Configuration Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Fixes all pre-commit hook failures in CI (
run-precommitworkflow):.pre-commit-config.yaml. The bundled pycodestyle 2.10.0 had known false positives when parsing f-strings — it treated Jinja{{ }}escapes as Python dict literals (E201/E202), text like\"not found in\"as membership tests (E713), and URL colons/SQL commas as missing whitespace (E231/E272). pycodestyle 2.12+ (in flake8 7.1.1) properly handles f-strings.\n- black/isort: Auto-formattedtest_microbatch_compiled_code.py\n- sqlfmt: Auto-formattedcapture_microbatch_compiled_code.sqlandget_compiled_code.sql\n- prettier: Auto-formatteddbt_project.yml\n\nLinear: CORE-798\n\n## Review & Testing Checklist for Human\n\n- [ ] Verify the flake8 7.1.1 upgrade doesn't introduce new lint rules that weren't previously enforced (the.flake8config ignores remain the same)\n- [ ] Spot-check the auto-formatted files to ensure no semantic changes were introduced\n\n### Notes\n\nAll changes are formatting-only — no logic changes. Pre-commit hooks pass locally on all files."Link to Devin session: https://app.devin.ai/sessions/98589940b9314e2fa0cf15c730715623
Requested by: @NoyaArie
Summary by CodeRabbit
Release Notes
Chores
Refactor