fix(core): Disable concurrency for package tasks#4276
Open
rf- wants to merge 1 commit into
Open
Conversation
These seem to have been unintentionally inheriting `"concurrent": true` from the list of targets a couple of levels up. The result is that all three subtasks of packaging appear to start simultaneously, even though the underlying work happens sequentially inside `@electron/packager`. This isn't really a problem at all in dev, but in CI it's confusing because it makes it look like, for example, the `prepare-native-dependencies` task has started before the `copy-files` task is finished, which isn't true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are appropriately documented (if applicable).The changes have sufficient test coverage (if applicable).Summarize your changes:
These seem to have been unintentionally inheriting
"concurrent": truefrom the list of targets a couple of levels up. The result is that all three subtasks of packaging appear to start simultaneously, even though the underlying work happens sequentially inside@electron/packager.This isn't really a problem in dev, but in CI it's confusing because it makes it look like, for example, the
prepare-native-dependenciestask has started before thecopy-filestask is finished, which isn't true.