build(deps): upgrade webpack-dev-server to v5.2.4#4274
Open
erickzhao wants to merge 2 commits into
Open
Conversation
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 4.15.2 to 5.2.4. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/main/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v4.15.2...v5.2.4) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-version: 5.2.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
webpack-dev-server v5 ships as CommonJS with `export = Server` and no ES default export. The default import still works under esModuleInterop (tsc and runtime both resolve it), but eslint-plugin-import's `import/default` rule flags the missing default. Suppress that rule on the import lines so the lint-and-build CI job passes. https://claude.ai/code/session_01BJULCvPjRZzh6voenUU4gN
erickzhao
changed the title
erickzhao
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
erikian
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Upgrades
webpack-dev-serverfrom v4.0.0 to v5.2.4 in both the root and webpack plugin package dependencies.Changes:
webpack-dev-serverdependency to v5.2.4 inpackage.jsonandpackages/plugin/webpack/package.jsonConfig.tsandWebpackPlugin.tsto handle webpack-dev-server v5's CommonJS export pattern (export =), which requires theimport/defaultrule to be disabled whenesModuleInteropis enabledThe import statement changes are necessary because webpack-dev-server v5 uses CommonJS
export =syntax rather than ES module exports, which can cause linting issues with theimport/defaultrule.Test Plan:
Existing tests pass with the updated dependency. The webpack plugin functionality remains unchanged as the public API of webpack-dev-server v5 is compatible with how it's being used in this codebase.
https://claude.ai/code/session_01BJULCvPjRZzh6voenUU4gN