fix: update Vite dependency in Vite templates#4265
Conversation
|
I intentionally used Vite |
|
Just checking in to see if there is anything else I can provide to make this easier to review. I’m happy to adjust the target Vite version if the maintainers prefer a different minimum. I chose Vite Thanks! |
|
We actually don't permit external contributors to update dependencies or touch lock files In this case I believe we've already updated vite quite substantially on the |
|
Thanks for the clarification. I understand the policy around external contributors not updating dependencies or touching lock files. Since our generated Electron Forge Vite apps are used in a production environment, I want to make sure we choose the safest path forward. I see that the If there is not a timeline yet, would you recommend that production users:
Happy to close this PR if the dependency update is already covered by the v8 work on |
Summarize your changes:
Updated the Vite dependency used by the Electron Forge Vite templates.
The existing templates generate projects with an older Vite/esbuild dependency chain. In some corporate environments, older esbuild versions are blocked by security scanners such as JFrog Xray. Updating the template dependency allows newly generated Electron Forge Vite apps to resolve to a newer esbuild version.
This updates:
packages/template/vite/tmpl/package.jsonpackages/template/vite-typescript/tmpl/package.jsonValidation:
Validated locally by generating a new Electron Forge Vite TypeScript app from the updated template and confirming that the app installs and runs successfully.
Commands used: