Skip to content

Commit 3aac467

Browse files
committed
test(profile): remove implicit root identity assumption
1 parent 68c0dd9 commit 3aac467

1 file changed

Lines changed: 4 additions & 26 deletions

File tree

src/test/java/io/github/easy4j/hermes/HermesOkHttpClientTest.java

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -33,40 +33,18 @@
3333
class HermesOkHttpClientTest {
3434

3535
@Test
36-
void shouldRouteManagedProfilesThroughOneSharedTransport() {
37-
AtomicReference<String> requestedPath = new AtomicReference<>();
38-
OkHttpClient external = new OkHttpClient.Builder()
39-
.addInterceptor(chain -> {
40-
requestedPath.set(chain.request().url().encodedPath());
41-
return new Response.Builder()
42-
.request(chain.request())
43-
.protocol(Protocol.HTTP_1_1)
44-
.code(200)
45-
.message("OK")
46-
.body(ResponseBody.create(
47-
"{\"id\":\"response-1\",\"choices\":[]}",
48-
MediaType.get("application/json")))
49-
.build();
50-
})
51-
.build();
36+
void shouldNotDeriveNamedProfileFromUncredentialedExternalTransport() {
37+
OkHttpClient external = new OkHttpClient.Builder().build();
5238
HermesHttpClientConfig httpConfig = new HermesHttpClientConfig();
5339
httpConfig.markUnsafeBaseUrlOverriddenForTest(true);
5440
httpConfig.setBaseUrl("http://127.0.0.1:8642/");
5541
HermesCliConfig cliConfig = new HermesCliConfig();
5642
cliConfig.setEnabled(false);
5743

5844
try (HermesClient client = new HermesClient(httpConfig, cliConfig, new ObjectMapper(), external)) {
59-
HermesClient sales = client.forProfile("sales");
60-
assertSame(sales, client.forProfile("sales"));
61-
assertSame(external, sales.getOkHttpClient());
62-
assertFalse(sales.isCliEnabled());
63-
sales.chatCompletion(new ChatRequest());
64-
assertEquals("/p/sales/v1/chat/completions", requestedPath.get());
45+
assertSame(external, client.getOkHttpClient());
46+
assertThrows(IllegalStateException.class, () -> client.forProfile("sales"));
6547
assertThrows(IllegalArgumentException.class, () -> client.forProfile("../sales"));
66-
assertThrows(IllegalStateException.class, () -> sales.forProfile("care"));
67-
68-
sales.close();
69-
assertSame(sales, client.forProfile("sales"));
7048
} finally {
7149
HermesOkHttpClientFactory.shutdown(external);
7250
}

0 commit comments

Comments
 (0)