Use sensible provisional splits for other-window... commands (via split-window-sensibly)#97
Open
monkeyjunglejuice wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
split-window-sensiblyinstead of hardcoding a right split inswitch-window--then-other-windowwhen there's just one single window.This respects the user preference in which direction to split a window, determied e.g. by
split-width-thresholdandsplit-height-threshold(there may be other influences, but that's the one I know of/use).Another UX improvement: When the split is created only so that an interactive other-window command can run, treat it as provisional and delete the redundant window again if the command quits or signals an error.
This avoids leaving an unused split behind when commands such as
switch-window-then-diredorswitch-window-then-find-fileare cancelled during their own interactive prompt.Tested with
switch-window-thresholdset to1and2; please try it out :)