fix: read the active days while the export streams, so an export that is the first visit of the day includes it

Author: mnapoli

app/Actions/CreateExport.php

@@ -37,7 +37,7 @@
  *     schema_version: int,
  *     exported_at: string,
  *     profile: array<string, bool|int|string|null>,
- *     active_days: array<mixed>,
+ *     active_days: Generator<int, string>,
  *     commits: Generator<int, array<string, mixed>>,
  *     polls: Generator<int, ExportPoll>,
  *     poll_votes: Generator<int, ExportPollVote>,
@@ -106,7 +106,7 @@ public function handle(User $user): array
                 'created_at' => $user->created_at->toIso8601String(),
                 'updated_at' => $user->updated_at->toIso8601String(),
             ],
-            'active_days' => DB::table('user_active_days')->where('user_id', $user->id)->oldest('seen_at')->pluck('seen_at')->all(),
+            'active_days' => $this->activeDays($user),
             'commits' => $this->commits($user),
             'polls' => $this->polls($user),
             'poll_votes' => $this->pollVotes($user),
@@ -244,6 +244,22 @@ private function pollVotes(User $user): Generator
         }
     }
 
+    /**
+     * The days the user was seen, oldest first. They are read while the export streams, after the request asking for it
+     * was recorded, so an export that is the first visit of the day includes that day.
+     *
+     * @return Generator<int, string>
+     */
+    private function activeDays(User $user): Generator
+    {
+        /** @var LazyCollection<int, object{seen_at: string}> $days */
+        $days = DB::table('user_active_days')->where('user_id', $user->id)->oldest('seen_at')->cursor();
+
+        foreach ($days as $day) {
+            yield $day->seen_at;
+        }
+    }
+
     /**
      * @return Generator<int, string>
      */

tests/Feature/Controllers/ExportControllerTest.php

@@ -466,7 +466,7 @@
 });
 
 it('exports the days the user was seen, oldest first, without the days of others', function (): void {
-    $user = User::factory()->create();
+    $user = User::factory()->create(['last_seen_at' => now()]);
     DB::table('user_active_days')->insert([
         ['user_id' => $user->id, 'seen_at' => '2026-10-21'],
         ['user_id' => $user->id, 'seen_at' => '2026-10-19'],
@@ -479,6 +479,17 @@
     expect($data['active_days'])->toBe(['2026-10-19', '2026-10-21']);
 });
 
+it('exports today when the export is the first visit of the day', function (): void {
+    $this->travelTo(now()->setDate(2026, 10, 30)->setTime(12, 0));
+    $user = User::factory()->create(['last_seen_at' => '2026-10-29']);
+    DB::table('user_active_days')->insert(['user_id' => $user->id, 'seen_at' => '2026-10-29']);
+
+    $response = $this->actingAs($user)->get(route('export'));
+    $data = json_decode($response->streamedContent(), true, flags: JSON_THROW_ON_ERROR);
+
+    expect($data['active_days'])->toBe(['2026-10-29', '2026-10-30']);
+});
+
 it('exports the devices approved for the app, oldest first', function (): void {
     $user = User::factory()->create();
     $older = Device::factory()->for($user)->create(['name' => 'devnull on iPad', 'approved_at' => now()->subWeek(), 'last_used_at' => now()->subDay()]);