forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 232
Feature: DeltaSpin for LCAO and PW base and DFTU for PW, both collinear and noncollinear spin (code change and UTs) #7384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dyzheng
wants to merge
42
commits into
deepmodeling:develop
Choose a base branch
from
dyzheng:feat/port-dftu-ds-code-v4
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
c582c1a
feat: sync DFT+U/DeltaSpin code from feat/dftu-pw-port-v2 (after merg…
dyzheng 1ebccc9
feat: remove infrastructure and misc changes from port
dyzheng 694f6fb
fix: restore critical files needed for compilation and stability
dyzheng f0a892a
feat: restore full source/ content from feat/dftu-pw-port-v2
dyzheng ac27932
test: enable 17_DS_DFTU test suite in CMakeLists
dyzheng 4ef2f30
Merge branch 'develop' into feat/port-dftu-ds-code-v4
mohanchen cfc3141
chore: remove changes unrelated to DFT+U/DeltaSpin port
dyzheng c82536b
Merge branch 'develop' of github.com:deepmodeling/abacus-develop into…
dyzheng a114228
fix: add npol==1 branch to CUDA DFT+U onsite_op kernel
dyzheng 8461df1
fix(ROCm): add npol==1 branch to DFT+U onsite_op kernel
dyzheng 790c690
fix: add spin_sign to npol==1 force/stress in CPU kernels
dyzheng 8338520
fix: don't mutate target_mag_ in direction_only mode
dyzheng 99c0439
fix: hoist per-atom resize calls before early continue in dftu.cpp
dyzheng e60c174
fix: remove stray diagnostic std::cout from STRU parse path
dyzheng dca95e5
fix: fix empty timer and add MPI sync in mix_uom
dyzheng f293daf
fix: remove incomplete lambda_strategy files
dyzheng 0921d0b
fix: drop non-existent cuSOLVER trtri fallback for CUDA < 11
dyzheng 7cc2e49
fix: fill D_I column-major in cal_PI_sub for correct zgemm result
dyzheng b4655a5
fix: make OperatorLCAO::set_current_spin virtual
dyzheng 85e87b0
fix: correct nspin=4 locale read-from-file access pattern in dftu_lca…
dyzheng bc79dba
fix: collapse 37 duplicate remove_definitions(-D__CUDA) to one line
dyzheng 137793e
fix: move parameter.h include from force_op.h and stress_op.h to cpp …
dyzheng cc84b99
fix: move parallel_orbitals.h and klist.h from elecstate_lcao.h to cpp
dyzheng c83cd91
fix: remove references to deleted lambda_update_strategies files from…
dyzheng 8677840
fix: remove dead becp cache state (becp_ready_, ik_becp_, is_becp_rea…
dyzheng aa6cf60
fix: remove dead cal_VU_pot_pw stub and declaration
dyzheng 7176bf6
fix: add npol==1 branches to GPU force/stress onsite kernels
dyzheng 2f82006
fix: restore nspin>=2 validation for sc_mag_switch
dyzheng 178724c
fix: set autoset magnetization along z-axis for nspin==2
dyzheng ebdbc79
fix: correct Hubbard energy weight for nspin==1 in PW DFT+U
dyzheng 5539972
fix: add isk parameter to DeltaSpin force/stress kernels, fix build e…
dyzheng 3f9e326
fix: remove orphaned DeltaSpin stress kernel code from CUDA stress_op.cu
dyzheng 61bbc64
fix: inline set_current_spin in OperatorLCAO header, fix test linker …
dyzheng 1610147
fix: update autoset magnetization test to expect z-axis for nspin==2
dyzheng 2c00c86
test: update result.ref and tighten scf_thr for direction-only tests
dyzheng 55a3f86
test: disable direction-only XY tests in CASES_CPU.txt
dyzheng 99d69b9
ci: add 17_DS_DFTU test step between 09_DeePKS and 10_others in test.yml
dyzheng 773f773
ci: remove 17_DS_DFTU from Other Unittests exclusion list
dyzheng a08cb35
Merge branch 'develop' into feat/port-dftu-ds-code-v4
mohanchen 26e6f56
Merge branch 'feat/port-dftu-ds-code-v4' of github.com:dyzheng/abacus…
dyzheng 94736ca
chore: remove temporary files and defer 17_DS_DFTU CI test
dyzheng b29fb18
Merge branch 'develop' into feat/port-dftu-ds-code-v4
dyzheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| set(CMAKE_HOST_SYSTEM "Linux-6.6.87.2-microsoft-standard-WSL2") | ||
| set(CMAKE_HOST_SYSTEM_NAME "Linux") | ||
| set(CMAKE_HOST_SYSTEM_VERSION "6.6.87.2-microsoft-standard-WSL2") | ||
| set(CMAKE_HOST_SYSTEM_PROCESSOR "x86_64") | ||
|
|
||
|
|
||
|
|
||
| set(CMAKE_SYSTEM "Linux-6.6.87.2-microsoft-standard-WSL2") | ||
| set(CMAKE_SYSTEM_NAME "Linux") | ||
| set(CMAKE_SYSTEM_VERSION "6.6.87.2-microsoft-standard-WSL2") | ||
| set(CMAKE_SYSTEM_PROCESSOR "x86_64") | ||
|
|
||
| set(CMAKE_CROSSCOMPILING "FALSE") | ||
|
|
||
| set(CMAKE_SYSTEM_LOADED 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
927 changes: 411 additions & 516 deletions
927
source/source_base/module_container/base/third_party/cusolver.h
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Blocker] Two problems with
mix_uom(and the matchingallocate_mixing_uomabove):timer::start("…","…"); timer::end("…","…");is called twice with no work between them — the timer reports zero. The actual work (init_mixing_data/push_data/mix_data) is entirely outside any timer span.uom_inis mixed locally on each rank with noMPI_Bcast/Allreducebefore or after. After a few Pulay steps the occupation matrices on different ranks will silently diverge. Compare tomix_dmrfor the canonical synchronized-mixing pattern.