You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two independent, low-risk items: (a) a new gga_grad input parameter selecting among 3 gradient evaluation methods for noncollinear GGA functionals, including a built-in spin-flip (SF) formulation; (b) a batch of build/compatibility/test-infrastructure fixes that are prerequisites for a clean CI but unrelated to any single feature.
Part A: Noncollinear GGA gga_grad
New input parameter gga_grad for noncollinear GGA calculations with 3 gradient methods.
gga_grad=3 uses a built-in spin-flip formulation (xc_functional_gga_noncol_sf_builtin.{h,cpp}, ~300 lines) instead of relying on libxc internals; SF builtin dispatch is disabled for other gga_grad values.
libxc interface updates (libxc_abacus.h, libxc_pot.cpp, libxc_tools.cpp) and xc_pot.cpp plumbing.
Docs: gga_grad documentation for noncollinear calculations.
Part B: Build / compatibility / test infrastructure
C++11 compatibility: replace make_unique with explicit new, use C++11-compatible is_same and unique_ptr::reset.
Remove stale use_paw parameter from HSolverPW/DiagoDavid constructor calls in esolver_ks_pw, esolver_sdft_pw, and hsolver_lrtd (libpaw was removed in PR delete libpaw (useless) #7273).
catch_properties.sh stress parsing: exclude the TOTAL-PRESSURE: line by matching numeric lines only, and use tail -3 (not head -3) to take the final converged stress in cell-relax runs.
MPI/FFTW cleanup order: restore proper finalization order to fix the segfault at MPI_Finalize.
Uninitialized local variables in hamilt2rho_single.
SDFT-GPU: restore the lazy-allocation guard for vkb in getgradq_vnl.
CI: fix pyabacus link error and CMake CMP0177 policy; sync pw_basis_k.cpp warning message with develop.
Restore develop's DeepKS files to fix LIBRI compilation; remove the obsolete, never-run NO_GO_deepks_UT/NO_KP_deepks_UT unit test scaffolding.
reserve→resize UB fixes in basic_funcs.cpp (3 occurrences).
Register the tests/17_DS_DFTU/ integration test suite skeleton (CASES_CPU.txt, CMakeLists registration, shared tests/PP_ORB/O.upf) so feature PRs can add cases incrementally.
Background
Background
Two independent, low-risk items: (a) a new
gga_gradinput parameter selecting among 3 gradient evaluation methods for noncollinear GGA functionals, including a built-in spin-flip (SF) formulation; (b) a batch of build/compatibility/test-infrastructure fixes that are prerequisites for a clean CI but unrelated to any single feature.Part A: Noncollinear GGA
gga_gradgga_gradfor noncollinear GGA calculations with 3 gradient methods.gga_grad=3uses a built-in spin-flip formulation (xc_functional_gga_noncol_sf_builtin.{h,cpp}, ~300 lines) instead of relying on libxc internals; SF builtin dispatch is disabled for othergga_gradvalues.libxcinterface updates (libxc_abacus.h,libxc_pot.cpp,libxc_tools.cpp) andxc_pot.cppplumbing.gga_graddocumentation for noncollinear calculations.Part B: Build / compatibility / test infrastructure
make_uniquewith explicitnew, use C++11-compatibleis_sameandunique_ptr::reset.use_pawparameter fromHSolverPW/DiagoDavidconstructor calls inesolver_ks_pw,esolver_sdft_pw, andhsolver_lrtd(libpaw was removed in PR delete libpaw (useless) #7273).catch_properties.shstress parsing: exclude theTOTAL-PRESSURE:line by matching numeric lines only, and usetail -3(nothead -3) to take the final converged stress in cell-relax runs.MPI_Finalize.hamilt2rho_single.vkbingetgradq_vnl.pw_basis_k.cppwarning message with develop.NO_GO_deepks_UT/NO_KP_deepks_UTunit test scaffolding.reserve→resizeUB fixes inbasic_funcs.cpp(3 occurrences).tests/17_DS_DFTU/integration test suite skeleton (CASES_CPU.txt, CMakeLists registration, sharedtests/PP_ORB/O.upf) so feature PRs can add cases incrementally.Scope
source/source_hamilt/module_xc/source/source_esolver/esolver_ks_pw.cpp,esolver_sdft_pw.cpp,source/source_hsolver/hsolver_lrtd.cpptests/integrate/tools/catch_properties.sh,tests/CMakeLists.txt,tests/PP_ORB/O.upfsource/source_lcao/module_deepks/test/(cleanup)Testing
gga_grad=1/2/3(energies and forces consistent across methods).Dependencies
Related
Split out from PR #7693.
Describe the solution you'd like
Above.
Task list only for developers
Notice Possible Changes of Behavior (Reminder only for developers)
No response
Notice any changes of core modules (Reminder only for developers)
No response
Notice Possible Changes of Core Modules (Reminder only for developers)
No response
Additional Context
No response
Task list for Issue attackers (only for developers)