Fix CI failures

Author: pfultz2

lib/importproject.cpp

@@ -1528,6 +1528,8 @@ struct ImportProject::PropertyValueExpander {
 
     PropertyValueExpander(ImportProject &project, const PropertiesMap &vars, std::string str, bool unknownAsEmpty = false)
         : mProject(project), mVars(vars), mStr(std::move(str)), mUnknownAsEmpty(unknownAsEmpty) {}
+    PropertyValueExpander(const PropertyValueExpander &) = delete;
+    PropertyValueExpander &operator=(const PropertyValueExpander &) = delete;
 
     bool hasValue(const std::string &name) const {
         if (mVars.count(name))
@@ -2331,6 +2333,8 @@ class ImportProject::ConditionParser {
 public:
     ConditionParser(ImportProject &project, const std::string &condition, const PropertiesMap &properties)
         : mProject(project), mCondition(condition), mVariables(properties) {}
+    ConditionParser(const ConditionParser &) = delete;
+    ConditionParser &operator=(const ConditionParser &) = delete;
 
     bool parse() {
         const std::string value = parseOr();
@@ -3116,6 +3120,8 @@ namespace {
             , thisFileFullPath(properties["MSBuildThisFileFullPath"]) {
             setMSBuildThis(filename, properties);
         }
+        MSBuildThis(const MSBuildThis &) = delete;
+        MSBuildThis &operator=(const MSBuildThis &) = delete;
 
         static void setMSBuildThis(const std::string &filename, PropertiesMap &properties) {
             // Normalize once so all subsequent path ops can assume '/' separators.
@@ -3149,6 +3155,8 @@ namespace {
         explicit DiscoveringGuard(bool &flag) : mFlag(flag) {
             mFlag = true;
         }
+        DiscoveringGuard(const DiscoveringGuard &) = delete;
+        DiscoveringGuard &operator=(const DiscoveringGuard &) = delete;
 
         ~DiscoveringGuard() {
             mFlag = false;
@@ -3161,6 +3169,8 @@ namespace {
 
         ImportStackGuard(std::unordered_set<std::string> &stack, std::string key)
             : mStack(stack), mKey(std::move(key)) {}
+        ImportStackGuard(const ImportStackGuard &) = delete;
+        ImportStackGuard &operator=(const ImportStackGuard &) = delete;
 
         ~ImportStackGuard() {
             mStack.erase(mKey);
@@ -3179,6 +3189,8 @@ namespace {
             : mCurrent(current), mPrev(current) {
             mCurrent = std::move(next);
         }
+        CurrentFileGuard(const CurrentFileGuard &) = delete;
+        CurrentFileGuard &operator=(const CurrentFileGuard &) = delete;
 
         ~CurrentFileGuard() {
             mCurrent = std::move(mPrev);

lib/symboldatabase.cpp

@@ -1570,6 +1570,7 @@ void SymbolDatabase::createSymbolDatabaseIncompleteVars()
     }
 }
 
+// cppcheck-suppress functionConst - has side effects
 void SymbolDatabase::createSymbolDatabaseEscapeFunctions()
 {
     for (const Scope& scope : scopeList) {
@@ -1840,6 +1841,7 @@ void SymbolDatabase::createSymbolDatabaseExprIds()
     }
 }
 
+// cppcheck-suppress functionConst - has side effects
 void SymbolDatabase::setArrayDimensionsUsingValueFlow()
 {
     // set all unknown array dimensions

test/testrefthunk.cpp

@@ -91,6 +91,7 @@ class TestRefThunk : public TestFixture {
         int y = 2;
         RefThunk<int> p(x);
         const RefThunk<int> q(y);
+        ASSERT(&p() == &x);
         p = q;
         ASSERT(&p() == &y);
         ASSERT_EQUALS(2, p());
@@ -100,6 +101,7 @@ class TestRefThunk : public TestFixture {
         int x = 1;
         int y = 2;
         RefThunk<int> p(x);
+        ASSERT(&p() == &x);
         // assignment rebinds, like std::reference_wrapper - it does not write through
         p = y;
         ASSERT(&p() == &y);