Const/reference member of non-class type inhibits uninitMemberVarNoCtor for all members

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: autoantwort

lib/checkclass.cpp

@@ -347,6 +347,7 @@ void CheckClassImpl::constructors()
             // Variables with default initializers
             bool hasAnyDefaultInit = false;
             bool hasAnySelfInit = false;
+            bool isDefaultConstructible = true;
             const bool cpp14OrLater = mSettings.standards.cpp >= Standards::CPP14;
             for (Usage& usage : usageList) {
                 const Variable& var = *usage.var;
@@ -355,11 +356,14 @@ void CheckClassImpl::constructors()
                 if (var.hasDefault()) {
                     usage.init = true;
                     hasAnyDefaultInit = true;
+                } else if (var.isReference() || (var.isConst() && !var.isClass())) {
+                    // the default constructor is deleted, so all members are initialized by every instance
+                    isDefaultConstructible = false;
                 } else if (cpp14OrLater && !hasAnySelfInit && isInitialized(usage, FunctionType::eConstructor)) {
                     hasAnySelfInit = true;
                 }
             }
-            if (!hasAnyDefaultInit && !hasAnySelfInit)
+            if (!isDefaultConstructible || (!hasAnyDefaultInit && !hasAnySelfInit))
                 continue;
 
             handleUnionMembers(usageList);
@@ -373,8 +377,8 @@ void CheckClassImpl::constructors()
                 if (var.typeScope() && var.typeScope()->numConstructors > 0)
                     continue;
 
-                // const and reference members without default initializer must be initialized by every instance
-                if (var.isConst() || var.isReference())
+                // a const member of class type is default constructed or makes the class not default constructible
+                if (var.isConst())
                     continue;
 
                 if (diagVars.count(&var) == 0)

test/testconstructors.cpp

@@ -798,13 +798,32 @@ class TestConstructors : public TestFixture {
                       "[test.cpp:8:9]: (warning) Member variable 'U::k' has no initializer. [uninitMemberVarNoCtor]\n",
                       errout_str());
 
-        check("struct S {\n" // const and reference members can't stay uninitialized
+        check("struct S {\n" // #15080
               "    int a = 0;\n"
               "    const int b;\n"
+              "    int k;\n"
+              "};\n");
+        ASSERT_EQUALS("", errout_str());
+
+        check("struct S {\n"
+              "    int a = 0;\n"
               "    int& c;\n"
+              "    int k;\n"
+              "};\n");
+        ASSERT_EQUALS("", errout_str());
+
+        check("struct S {\n"
+              "    int a = 0;\n"
               "    const int* d;\n"
               "};\n");
-        ASSERT_EQUALS("[test.cpp:5:16]: (warning) Member variable 'S::d' has no initializer. [uninitMemberVarNoCtor]\n", errout_str());
+        ASSERT_EQUALS("[test.cpp:3:16]: (warning) Member variable 'S::d' has no initializer. [uninitMemberVarNoCtor]\n", errout_str());
+
+        check("struct S {\n"
+              "    std::string a;\n"
+              "    const std::string s;\n"
+              "    int k;\n"
+              "};\n");
+        ASSERT_EQUALS("[test.cpp:4:9]: (warning) Member variable 'S::k' has no initializer. [uninitMemberVarNoCtor]\n", errout_str());
 
         check("struct S {\n"
               "    const std::array<std::uint8_t, 2> a;\n"