Acknowledge webhook creation ping#10
Open
mhkeller wants to merge 1 commit into
Open
Conversation
This was referenced Nov 10, 2014
Author
|
Checking in on this. |
|
@mhkeller if you're still using this library, I've created a fork which supports Ping events and has unit tests. Check it out at: https://www.npmjs.com/package/githooked |
Author
|
@ScottONeal awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub sends a ping even on Webhook creation: https://developer.github.com/webhooks/#ping-event
But since it doesn't follow the structure that
lib/index.jsis expecting, that script throws an error, such as when it can't find a string forpayload.ref.You could do fancier things to handle this such as emit a
pingevent but this fix will stop the script from breaking for now.