refactor: fix phpstan errors in BaseBuilder

Author: paulbalandan

system/Database/BaseBuilder.php

@@ -34,7 +34,7 @@ class Builder extends BaseBuilder
     /**
      * ORDER BY random keyword
      *
-     * @var array
+     * @var list<string>
      */
     protected $randomKeyword = [
         '"DBMS_RANDOM"."RANDOM"',

system/Database/OCI8/Builder.php

@@ -30,7 +30,7 @@ class Builder extends BaseBuilder
     /**
      * ORDER BY random keyword
      *
-     * @var array
+     * @var list<string>
      */
     protected $randomKeyword = [
         'RANDOM()',
@@ -140,7 +140,7 @@ public function decrement(string $column, int $value = 1)
      * we simply do a DELETE and an INSERT on the first key/value
      * combo, assuming that it's either the primary key or a unique key.
      *
-     * @param array|null $set An associative array of insert values
+     * @param array<string, mixed>|null $set An associative array of insert values
      *
      * @return BaseResult|false|Query|string
      *

system/Database/Postgre/Builder.php

@@ -36,7 +36,7 @@ class Builder extends BaseBuilder
     /**
      * ORDER BY random keyword
      *
-     * @var array
+     * @var list<string>
      */
     protected $randomKeyword = [
         'NEWID()',
@@ -644,7 +644,7 @@ protected function compileSelect($selectOverride = false): string
      * Compiles the select statement based on the other functions called
      * and runs the query
      *
-     * @return ResultInterface
+     * @return false|ResultInterface|string
      */
     public function get(?int $limit = null, int $offset = 0, bool $reset = true)
     {

system/Database/SQLSRV/Builder.php

@@ -44,7 +44,7 @@ class Builder extends BaseBuilder
     /**
      * ORDER BY random keyword
      *
-     * @var array
+     * @var list<string>
      */
     protected $randomKeyword = [
         'RANDOM()',

system/Database/SQLite3/Builder.php

@@ -37,6 +37,8 @@
 
 /**
  * Framework test case for PHPUnit.
+ *
+ * @template TDb of BaseConnection = BaseConnection
  */
 abstract class CIUnitTestCase extends TestCase
 {
@@ -147,7 +149,7 @@ abstract class CIUnitTestCase extends TestCase
     /**
      * Our database connection.
      *
-     * @var BaseConnection
+     * @var TDb
      */
     protected $db;
 

system/Test/CIUnitTestCase.php

@@ -23,15 +23,12 @@
 
 /**
  * @internal
+ *
+ * @extends CIUnitTestCase<MockConnection>
  */
 #[Group('Others')]
 final class InsertTest extends CIUnitTestCase
 {
-    /**
-     * @var MockConnection
-     */
-    protected $db;
-
     protected function setUp(): void
     {
         parent::setUp();

tests/system/Database/Builder/InsertTest.php

@@ -25,11 +25,6 @@
 #[Group('Others')]
 final class UnionTest extends CIUnitTestCase
 {
-    /**
-     * @var MockConnection
-     */
-    protected $db;
-
     protected function setUp(): void
     {
         parent::setUp();

tests/system/Database/Builder/UnionTest.php

@@ -22,15 +22,12 @@
 
 /**
  * @internal
+ *
+ * @extends CIUnitTestCase<MockConnection>
  */
 #[Group('Others')]
 final class UpdateTest extends CIUnitTestCase
 {
-    /**
-     * @var MockConnection
-     */
-    protected $db;
-
     protected function setUp(): void
     {
         parent::setUp();

tests/system/Database/Builder/UpdateTest.php

@@ -25,11 +25,6 @@
 #[Group('Others')]
 final class WhenTest extends CIUnitTestCase
 {
-    /**
-     * @var MockConnection
-     */
-    protected $db;
-
     protected function setUp(): void
     {
         parent::setUp();