Add a parameter the Options in some methods

[SorceryAdmin]

would be nice to have the option in 👍

1. ClickOptions:

•   X,Y point of the click so we can use a point instead of middle default.
  

2. WaitForSelectorOptions:

•   a bool to choose if return null  if selector timeout instead of throwing exception.(in fact for all waits will be nice)
  

[amaitland]

X,Y point of the click so we can use a point instead of middle default.

puppeteer sharp supports an OffSet, we should be able to port that over.

https://github.com/hardkoded/puppeteer-sharp/blob/a2b860b421fefe2caa5196608266524ac5ef3c8a/lib/PuppeteerSharp/Input/ClickOptions.cs#L26

Would that meet your requirements?

a bool to choose if return null if selector timeout instead of throwing exception.(in fact for all waits will be nice)

Could you just write an extension method that catches the WaitTaskTimeoutException exception and returns null?

[SorceryAdmin]

the click offset is great, if you could add for tap will be also great.

I did the extension but for reasons I'm still determining when multithreading the app crash with libcef errors if too many WaitTaskTimeoutException have occurred even when managed.

Overall latest libcef releases have been very sensible to exceptions. Thats why I asked the possibility.

[amaitland]

Copying and pasting comment from #61 (comment)

Ben easier to keep the discussion in the same thread.

ok this may be a little tricky to explain but I will try.
Having this declarations:

public Dictionary<object, Delegate> UserActions = new Dictionary<object, Delegate>();

then declaring

    protected async Task InitializeDevToolsContext()
    {
         await submitBrowser.InvokeOnUiThreadIfRequired(async () =>
        {
            if (DevToolsContext == null)
                      DevToolsContext = await submitBrowser.CreateDevToolsContextAsync();
        
            
        });   
    }
UserActions.Add("TypeValue", (string querySelector, string value) => this.TypeValue(querySelector, value));
    public async Task TypeValue(string querySelector, string value)
    {
        try
        {
            await InitializeDevToolsContext();
            await submitBrowser.InvokeOnUiThreadIfRequired(async () =>
            {
                await DevToolsContext.QuerySelectorAsync(querySelector);
                await  DevToolsContext.TypeAsync(querySelector,value);
            });
        }
        catch(Exception err) {
                ErrorReporter(err);
           }

    }

then when executed

UserActions["TypeValue"].DynamicInvoke(arguments.ToArray());

QuerySelectorAsync just hangs and never comes back and when it works the exceptions just kill this.

[amaitland]

Overall latest libcef releases have been very sensible to exceptions. Thats why I asked the possibility.

Just as a general reference the CEF threads are all unmanaged, so propagating a managed exception onto one of them is basically catastrophic.

I did the extension but for reasons

Just so we're on the same page, example of what I was thinking would look like

public static async Task<ElementHandle> WaitForSelectorExAsync(this DevToolsContext devToolsContext, string selector, WaitForSelectorOptions options = null)
{

    try
    {
        return await devToolsContext.WaitForSelectorAsync(selector, options).ConfigureAwait(false);
    }
    catch (WaitTaskTimeoutException ex)
    {
        Trace.TraceError($"{nameof(WaitForSelectorExAsync)} timed out after {ex.Timeout} ms for selector '{selector}' with options: {options?.Visible}, {options?.Hidden}");

        return null;
    }
}

[amaitland]

I will have a look to see what's involved porting that feature.

I'm still determining when multithreading the app crash with libcef errors if too many WaitTaskTimeoutException have occurred even when managed.

Are you able to provide a example? If I can reproduce the problem then I can look at how to handle that scenario better.

[amaitland]

I will have a look to see what's involved porting that feature.

First draft at #61

Still need to debug a failing test.

Need to upgrade to latest CefSharp version, PR #59

[SorceryAdmin]

Will update all my reference code to latest release and will let you know how all goes.
My reason to do that Dynamic invoke is to have mini scripts to add functions similar to chrome extensions but for this particular case useful for report automation on some views for the admins. Like macros use to be for excel

[amaitland]

I've created #63 to add a new option to return null instead of throw timeout exception. I'm not 100% sure on the property name, input welcome.