From cfa13529abdfafbacd2114d6ac213adf6f3fc662 Mon Sep 17 00:00:00 2001 From: Adam Bratschi-Kaye Date: Wed, 16 Sep 2026 14:06:23 +0000 Subject: [PATCH 1/7] Add target specific CI check jobs --- .github/workflows/ci.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 598dd5f..40353a4 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -51,8 +51,12 @@ jobs: - name: rust version run: cargo --version - - name: check - run: cargo check --workspace --all --bins --examples + - name: check p2 + run: cargo check --workspace --all --bins --examples --target wasm32-wasip2 + + - name: check p3 + if: matrix.rust == 'nightly' + run: cargo check --workspace --all --bins --examples --target wasm32-wasip3 - name: wstd p2 tests run: cargo test -p wstd -p wstd-axum --target wasm32-wasip2 -- --nocapture From b57c68b6ae4222d1a5aec8ab5fb37503fef06f97 Mon Sep 17 00:00:00 2001 From: Adam Bratschi-Kaye Date: Thu, 17 Sep 2026 17:41:14 +0000 Subject: [PATCH 2/7] doc and clippy as well --- .github/workflows/ci.yaml | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 40353a4..adc7f1f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -83,11 +83,21 @@ jobs: - name: fmt run: cargo fmt --all -- --check - - name: Docs - run: cargo doc + - name: Docs p2 + run: cargo doc --target wasm32-wasip2 - - name: Clippy - run: cargo clippy --all + - name: Docs p3 + if: matrix.rust == 'nightly' + run: cargo doc --target wasm32-wasip3 + + - name: Clippy p2 + run: | + cargo clippy --workspace --exclude test-programs --target wasm32-wasip2 + cargo clippy -p test-programs + + - name: Clippy p3 + if: matrix.rust == 'nightly' + run: cargo clippy --workspace --exclude test-programs --target wasm32-wasip3 verify-publish: name: Verify publish From 93e282c457f966ce651b8009588e230c8e9da213 Mon Sep 17 00:00:00 2001 From: Adam Bratschi-Kaye Date: Thu, 17 Sep 2026 18:18:46 +0000 Subject: [PATCH 3/7] publish for wasi targets --- ci/publish.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ci/publish.rs b/ci/publish.rs index 66867ce..17e0495 100644 --- a/ci/publish.rs +++ b/ci/publish.rs @@ -322,6 +322,10 @@ fn publish(krate: &Crate) -> bool { .arg("publish") .current_dir(krate.manifest.parent().unwrap()) .arg("--no-verify") + .arg("--target") + .arg("wasm32-wasip2") + .arg("--target") + .arg("wasm32-wasip3") .status() .expect("failed to run cargo"); if !status.success() { @@ -362,6 +366,10 @@ fn verify(crates: &[Crate]) { let mut cmd = Command::new("cargo"); cmd.arg("package") .arg("--allow-dirty") + .arg("--target") + .arg("wasm32-wasip2") + .arg("--target") + .arg("wasm32-wasip3") .arg("--manifest-path") .arg(&krate.manifest) .env("CARGO_TARGET_DIR", "./target"); From 669d2f65cd9879d9a19cdd6102174f2438d96a44 Mon Sep 17 00:00:00 2001 From: Adam Bratschi-Kaye Date: Thu, 17 Sep 2026 18:23:52 +0000 Subject: [PATCH 4/7] use nightly to publish --- .github/workflows/ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index adc7f1f..3d3df63 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -106,6 +106,8 @@ jobs: steps: - uses: actions/checkout@master - uses: ./.github/actions/install-rust + with: + toolchain: nightly - run: rustc ci/publish.rs # Make sure we can bump version numbers for the next release - run: ./publish bump From b6f50bd5a445f9b1959defa8988b2ac31ae67ffd Mon Sep 17 00:00:00 2001 From: Adam Bratschi-Kaye Date: Thu, 17 Sep 2026 18:34:16 +0000 Subject: [PATCH 5/7] use nightly for fmt and clippy checks --- .github/workflows/ci.yaml | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3d3df63..5d3bef1 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -79,26 +79,23 @@ jobs: steps: - uses: actions/checkout@master - uses: ./.github/actions/install-rust + with: + toolchain: nightly - name: fmt run: cargo fmt --all -- --check - - name: Docs p2 - run: cargo doc --target wasm32-wasip2 - - - name: Docs p3 - if: matrix.rust == 'nightly' - run: cargo doc --target wasm32-wasip3 + - name: Docs + run: | + cargo doc --target wasm32-wasip2 + cargo doc --target wasm32-wasip3 - - name: Clippy p2 + - name: Clippy run: | cargo clippy --workspace --exclude test-programs --target wasm32-wasip2 + cargo clippy --workspace --exclude test-programs --target wasm32-wasip3 cargo clippy -p test-programs - - name: Clippy p3 - if: matrix.rust == 'nightly' - run: cargo clippy --workspace --exclude test-programs --target wasm32-wasip3 - verify-publish: name: Verify publish if: github.repository_owner == 'bytecodealliance' From 22689719a228b2876cd69862c14f26ef3509b18e Mon Sep 17 00:00:00 2001 From: Adam Bratschi-Kaye Date: Thu, 17 Sep 2026 18:36:16 +0000 Subject: [PATCH 6/7] explicitly install rustfmt on nightly --- .github/actions/install-rust/action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/install-rust/action.yml b/.github/actions/install-rust/action.yml index 3c16f0c..e89bd2d 100644 --- a/.github/actions/install-rust/action.yml +++ b/.github/actions/install-rust/action.yml @@ -37,6 +37,7 @@ runs: if [ "${{ inputs.toolchain }}" = "nightly" ]; then rustup target add wasm32-wasip3 + rustup component add rustfmt fi # Save disk space by avoiding incremental compilation. Also turn down From 52bbf798f64a6e37fe3ba2c7c3d8c9ae42e3158e Mon Sep 17 00:00:00 2001 From: Adam Bratschi-Kaye Date: Thu, 17 Sep 2026 18:39:04 +0000 Subject: [PATCH 7/7] explictly install clippy on nightl --- .github/actions/install-rust/action.yml | 1 + .github/workflows/ci.yaml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.github/actions/install-rust/action.yml b/.github/actions/install-rust/action.yml index e89bd2d..099c0dc 100644 --- a/.github/actions/install-rust/action.yml +++ b/.github/actions/install-rust/action.yml @@ -38,6 +38,7 @@ runs: if [ "${{ inputs.toolchain }}" = "nightly" ]; then rustup target add wasm32-wasip3 rustup component add rustfmt + rustup component add clippy fi # Save disk space by avoiding incremental compilation. Also turn down diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 5d3bef1..35e38e6 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -54,6 +54,8 @@ jobs: - name: check p2 run: cargo check --workspace --all --bins --examples --target wasm32-wasip2 + # TODO: remove all nightly conditions for p3 targets once wasm32-wasip3 is + # stable. - name: check p3 if: matrix.rust == 'nightly' run: cargo check --workspace --all --bins --examples --target wasm32-wasip3