Skip to content

Commit e137035

Browse files
committed
Drop the note about the repository being private
1 parent 5678f8b commit e137035

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,9 @@ jobs:
9090
if line.startswith("linkedin-scraper"):
9191
continue # run below, so the exit code can be checked
9292
if line.startswith("pip install"):
93-
# While the repository is private nobody, including this
94-
# runner, can fetch that URL, so fall back to the checkout.
95-
# When it goes public the check arms itself and tests the
96-
# exact line a reader pastes. Nothing to remember later.
93+
# The repository is public, so this installs the exact line a
94+
# reader pastes. On a private fork the URL is unreachable, and
95+
# the check falls back to the checkout on its own.
9796
url = line.split("git+", 1)[1].strip() if "git+" in line else ""
9897
line = "\n".join([
9998
f'repo="{url}"',

‎.github/workflows/live.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ jobs:
8282
*zendesk.com/*) continue ;; # answers 403 to anything that is not a browser
8383
*mcp.brightdata.com/*) continue ;; # carries a placeholder token; nothing to check without a real one
8484
*api.brightdata.com/*) continue ;; # needs the token; the field-table step below calls it for real
85-
*github.com/brightdata/linkedin-scraper-python*) [ "$public" = "200" ] || continue ;; # private for now
85+
*github.com/brightdata/linkedin-scraper-python*) [ "$public" = "200" ] || continue ;; # unreachable on a private fork
8686
esac
8787
code=$(curl -s -o /dev/null -L --retry 3 --max-time 30 -A "Mozilla/5.0" -w '%{http_code}' "$url" || echo 000)
8888
if [ "$code" = "200" ]; then echo "200 $url"; else echo "::error::$code $url"; failed=1; fi

‎README.md‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ pip install git+https://github.com/brightdata/linkedin-scraper-python
7575
linkedin-scraper satyanadella reidhoffman
7676
```
7777

78-
While this repository is private, that install line works only for people with
79-
access to it.
80-
8178
```
8279
Fetching 2 LinkedIn profiles: satyanadella, reidhoffman
8380
One job for all of them, usually one to three minutes. One credit per profile.

0 commit comments

Comments
 (0)