W45 Lib Team Call

[nondiremanuel]

📆 Tues November 7, 2023 12:00 UTC
📍 Discord General Voice Channel

Please add comments to this issue to suggest issues and PRs to discuss.

General Discussion Items

• BDK 1.0 milestones and timeline (add roadmap for 2023-24 bitcoindevkit.org#162: high level functional roadmap description blog post) -> upgrade rust-bitcoin to v0.31.1 (added an issue to alpha.3, but it could require another alpha for the miniscript part if it's not ready in time)
• BDK Review Club: no review scheduled
• Any review begs? 🙏 ci issue was fixed, PRs need to be rebased
• Blockers? 🪨 chore: fix MSRV for flate2 bdk#1182 blocking some PRs, needs review

Top BDK 1.0 PRs and issues

alpha.3

Recently merged:

Ready to be merged:

Changes requested:

Need Review:

• LocalChain with hardwired genesis block bdk#1178: review ongoing
• Add CreateTxError and use as error type for TxBuilder::finish() bdk#1028: review ongoing, with the caveat that after CI fixes are made on master branch it will need to be rebased -> still in progress after some comments
• Add Wallet::list_output method bdk#1190: review ongoing -> probably ready to be merged
• Clean up clippy allows bdk#1186: fixes Way too many clippy::allow bdk#1127, needs review -> check if the comments were all addressed or not (and rebase due to ci fix)
• rename scan to scan_with_keychain bdk#1117: waiting to be reviewed
• Further improve unconfirmed tx conflict resolution bdk#1109: changes approved by Lloyd. Depending on chore: fix MSRV for flate2 bdk#1182, it could need rebase after ci fix
• Bump MSRV to 1.63.0 bdk#1183: needs to wait LDK's Bump MSRV to rustc 1.63.0 lightningdevkit/rust-lightning#2681 before merging -> it will be moved back to draft
• ref(hwi): Move hwi out of bdk bdk#1161: waiting to be reviewed
• Implement default index_tx method bdk#1176: seems to impact the API, so we assign it to alpha.3 for the moment. Waiting to be reviewed -> actually still in progress
• ci: replace toolchain bdk#1156: it will need to be closed if we land to Nix ci

In progress:

• WIP: persist descriptor in wallet bdk#1167: WIP (daniela) -> probably it will be substituted by a new PR, close to be opened
• The Wallet.is_mine() function should return K bdk#1042: WIP -> code already implemented. For now using KeychainKind
• Introduce block-by-block API to bdk::Wallet and add RPC wallet example bdk#1172: WIP, replaces 1106. -> moved to Needs Review
• fix(electrum): fixed chain sync issue bdk#1145: needs to be continued after discarding fix(electrum): fixed chain sync issue bdk#1163 solution -> it doesn't seem to fix completely the related issue Calling example_electrum sync on an unconfirmed tx may result in the tx being stuck as unconfirmed eternally (according to the cli)) bdk#1125. It could be merged but keeping the issue open, unlinking it
• Syncing/Rescanning super issue bdk#1195: issue collecting different requirements for syncing. To be discussed. The work was started in Add wallet sync_request and full_scan_request functions bdk#1194 -> same PR or different one to implement Lloyd's suggestion
• fix: remove deprecated max_satisfaction_weight bdk#1115: No update. Still on hold, needs some comment from evan and/or Lloyd. The old method has some problems but it's not clear the impact of it. Degree of complexity (and consequently milestone) needs to be discussed
• feat: add bdk_sqlite crate implementing PersistBackend bdk#1128: No update. Another approach has to be tried -> will ping on discord
• Refactor: Migrate bdk::FeeRate to bitcoin::FeeRate bdk#1141: No update. Important to keep it since it affects the Wallet API. Not clear if it is close to end or not. Probably simplified by last rust-bitcoin version
• Test electrum ext bdk#979: No update. Related to fix(electrum): fixed chain sync issue bdk#1145, so included in alpha.3 -> waiting for chore: extract TestEnv into separate crate bdk#1171. Moved to beta since it is test related

To Do:

• Rename electrum's sync/scan bdk#1154: discord discussion on scan vs rescan, still ongoing. Probably included in super issue Syncing/Rescanning super issue bdk#1195 (above) -> poll on discord
• Coinbase transaction that is not anchored in the best chain should always be filtered out bdk#1144: No update
• Taproot PSBT finalization fails often when signing with internal key bdk#1142: Bug to be investigated before alpha.3 and then evaluate the priority. mgravitt is asking for updates -> daniela will have a look on it (and we can tell max that it is ongoing)
• Reintroduce a way verify a transaction bdk_wallet#127: new on transaction verification -> it shouldn't be very hard and lower priority for alpha.3
• build(esplora): Add async-https-rustls flag to esplora client bdk#1179: useful for android binding, possibly to be included in the next bdk_esplora release. Since it should be quick adding a flag, we added to alpha.3

Milestone TBD:

• Introduce new bdk_coin_select implementation bdk#1072: WIP (evan): is it correct to keep it high priority being it labeled for 2.0 release?
• doc: Improve TxGraph & co docs bdk#1188: needs review, but which milestone should it be assigned to? -> moved to alpha.3 since it should be small and makes things clearer
• Wallet's persistence should have a fixed "header" section bdk_wallet#125 -> it could be required for alpha.3 since it could have breaking changes (ask also to evan)

Other updates for future releases

• ci: move to Nix bdk#1165: ci to Nix; possibly in the future also for the ffi repo. Put in beta, if it comes earlier we can include it in alpha.3
• Upgrade bitcoin/miniscript dependencies bdk#1177: adjustments needed for the release of rust-bitcoin v0.31.0-rc1: since not necessary for the 1.0 beta, put in 2.0 but if we can get it sooner it could be useful. update: rust-bitcoin release is out but still working on miniscript; fixes deprecation of is_coin_base (Rename is_coin_base to is_coinbase bdk#1191)
• chore: extract TestEnv into separate crate bdk#1171: in beta, if it comes earlier we can include it in alpha.3
• doc(bdk): Clarify the absolute_fee docs bdk#1158: needs review (it should be a quick one) -> very small change, moved to alpha.3

New Projects and Support

Upcoming Events

• BTC Azores Sept 23-24
• PlanB Lugano Oct 20-21
• Africa Bitcoin Conference (Accra) Dec 1-3 2023

🌅 Future Call Notes

📜 Past Call Notes