From f4ce9da384dad0ba7a7b47b342bc0bec2d2ffb37 Mon Sep 17 00:00:00 2001
From: Richard Levasseur <richardlev@gmail.com>
Date: Mon, 26 Oct 2026 21:52:23 -0700
Subject: [PATCH] agents: avoid complex inline expressions and refine workflow
 guardrails

Complex inline expressions and dense boolean chains in workflow
definitions and code obscure intent, complicate debugging, and increase
the risk of logic bugs or improper input sanitization.

Update agent code style rules to disfavor dense inline expressions and
dense one-liners in favor of explicit statements and intermediate
steps. Refine workflow security guardrails to recommend dedicated
ref-sanitization steps, simplify failure-reporting job condition
predicates, and clarify the rationale for using `printf` over
`echo`.
---
 .agents/rules/code-style.md               |  5 ++++-
 .agents/rules/github_actions_workflows.md | 13 +++++++++----
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/.agents/rules/code-style.md b/.agents/rules/code-style.md
index bc2df1aa52..52be2ac057 100644
--- a/.agents/rules/code-style.md
+++ b/.agents/rules/code-style.md
@@ -1,7 +1,7 @@
 ---
 trigger: glob
 description: Cross-language code style, control flow, and CLI conventions
-globs: "*.py,*.sh,*.cc,*.h,*.go,*.bzl,*.bazel"
+globs: "*.py,*.sh,*.cc,*.h,*.go,*.bzl,*.bazel,*.yaml,*.yml"
 ---
 
 # Code Style Rules
@@ -31,6 +31,9 @@ Order definitions within a file as:
   domain state.
 * Do not write nested comprehensions or comprehensions with multiple `for`
   clauses; use explicit loops.
+* Avoid long or complex inline expressions (e.g. multi-condition ternaries,
+  compound boolean chains, or dense one-liners). Break them into named
+  intermediate variables, prior preparation steps, or explicit statements.
 
 ## CLI & Flags
 * Comment non-obvious flags (`--force`), non-default schemes, subtle arguments
diff --git a/.agents/rules/github_actions_workflows.md b/.agents/rules/github_actions_workflows.md
index b5c5c77160..4b489e57d2 100644
--- a/.agents/rules/github_actions_workflows.md
+++ b/.agents/rules/github_actions_workflows.md
@@ -65,7 +65,10 @@ globs: ".github/workflows/**,.github/actions/**,.github/dependabot.yml"
 * **Untrusted Git Ref Names (`github.head_ref`, `github.ref_name`)**: Treat
   branch and tag names as untrusted input. Git ref names allow quotes (`'`, `"`)
   and shell metacharacters (`;`, `&`, `|`, `$()`, `` ` ``); reject or guard
-  against quotes and `#` before writing refs to `.bazelrc`.
+  against quotes and `#` before writing refs to `.bazelrc`. Sanitize the value
+  in a dedicated prior step (e.g. stripping characters outside
+  `[a-zA-Z0-9._/-]`) and output to `$GITHUB_OUTPUT` rather than writing complex
+  inline expression guards.
 * **CLI Argument & Option-Flag Injection**: Validate untrusted inputs (such as
   slash-command arguments from issue or PR comments) against strict allowlist
   regexes before writing to `$GITHUB_OUTPUT` or passing to tools. Separate
@@ -74,7 +77,9 @@ globs: ".github/workflows/**,.github/actions/**,.github/dependabot.yml"
 * **Authorize Before Mutating State**: In comment- or event-triggered workflows,
   verify actor authorization (`author_association` or user allowlist) before
   writing to `$GITHUB_OUTPUT` or `$GITHUB_ENV`, posting reactions, or triggering
-  failure-reporting jobs.
+  failure-reporting jobs. In failure-reporting jobs, gate on
+  `needs.parse_step.result == 'success' && contains(needs.*.result, 'failure')`
+  without adding redundant `outputs.command != ''` predicates.
 * **Single-Line `$GITHUB_OUTPUT` and `$GITHUB_ENV` Writes**: Reject `\n` and
   `\r` in keys and values before writing `key=value` lines to `$GITHUB_OUTPUT`
   or `$GITHUB_ENV`. In line-anchored regexes over comment or PR bodies, match
@@ -82,8 +87,8 @@ globs: ".github/workflows/**,.github/actions/**,.github/dependabot.yml"
   rather than `\s` or `.`.
 * **Suppress Untrusted Stdout in Privileged Jobs**: Never echo raw PR bodies,
   titles, or comment bodies to stdout (pass `--quiet` to `grep`, and use
-  `printf '%s\n'` instead of `echo`), preventing `::...::` workflow command
-  injection.
+  `printf '%s\n'` instead of `echo` to avoid option-flag parsing and escape
+  expansion), preventing `::...::` workflow command injection.
 
 ## Workflow Scripts & Testing
 * **Separate Script Files (No Inline Scripts)**: Factor non-trivial scripts