From 0d576b57e4a9a9e99bd621cdf4affc6f2b38e5b5 Mon Sep 17 00:00:00 2001 From: "Stanko K.R." Date: Tue, 8 Sep 2026 09:04:17 +0200 Subject: [PATCH] Leave Previously Seen out of the mail help bar MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tab is already on screen with its number on it, so the help bar was spending a slot to repeat what the nav row says. The key still works and the docs still describe it. The test that pinned the binding was there to tell the list's help from the seen screen's, and there is no longer a difference to tell. What it checked that still matters — the seen screen offering the same thread actions the box list does — stays. --- internal/tui/mail.go | 1 - internal/tui/mail_test.go | 12 ++++-------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/internal/tui/mail.go b/internal/tui/mail.go index 7e2c3937..65385d41 100644 --- a/internal/tui/mail.go +++ b/internal/tui/mail.go @@ -1060,7 +1060,6 @@ func (v *mailView) HelpBindings() []helpBinding { helpBinding{"t", "trash"}, helpBinding{"!", "spam"}, ignoreBinding, - helpBinding{"9", "previously seen"}, helpBinding{"ctrl+r", "reload"}, ) if v.postingList.cover != coverNone { diff --git a/internal/tui/mail_test.go b/internal/tui/mail_test.go index 349246d8..45a1fde5 100644 --- a/internal/tui/mail_test.go +++ b/internal/tui/mail_test.go @@ -4101,22 +4101,18 @@ func TestMailViewMovePickerOnTheSeenScreenLeavesTheImboxOut(t *testing.T) { } } -func TestMailViewHelpBindingsNamePreviouslySeen(t *testing.T) { +// Previously Seen holds ordinary threads, so its screen offers the same actions the +// box list does rather than being a place you can only read from. +func TestMailViewSeenScreenHelpOffersTheThreadActions(t *testing.T) { v := mailWithPostings() - if !hasHelpBinding(v.HelpBindings(), "9") { - t.Error("the list help should name 9") - } - v.seenActive = true + bindings := v.HelpBindings() for _, key := range []string{"enter", "space", "ctrl+b", "a", "l", "u", "t", "v", "b", "n"} { if !hasHelpBinding(bindings, key) { t.Errorf("seen screen help misses %q: %+v", key, bindings) } } - if hasHelpBinding(bindings, "9") { - t.Error("the seen screen help should not name 9") - } } func TestMailViewRefusesAPostingWithoutAThread(t *testing.T) {