You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. Unrelated change inside PR #241.cdk/src/handlers/linear-webhook-processor.ts:34 flips DEFAULT_LABEL_FILTER from bgagent to abca. This belongs in its own PR — it has nothing to do with the screenshot pipeline.
2. The four documentation/code sites disagree on the default. Drift across:
The default trigger label should be one consistent value across processor code, CLI defaults, and documentation. The change should ship in a dedicated PR with a migration note.
Current behavior
PR #241 silently flips the processor default to abca while the CLI and docs still tell users it is bgagent. Any onboarded project whose LinearProjectMappingTable row lacks an explicit label_filter would silently switch trigger label on deploy.
Proposed solution
Open a separate PR (against main, not stacked on PR #241) that:
Component
Adapters (Linear) / CDK / CLI / Documentation
Problem
Two issues bundled into one:
1. Unrelated change inside PR #241.
cdk/src/handlers/linear-webhook-processor.ts:34flipsDEFAULT_LABEL_FILTERfrombgagenttoabca. This belongs in its own PR — it has nothing to do with the screenshot pipeline.2. The four documentation/code sites disagree on the default. Drift across:
cdk/src/handlers/linear-webhook-processor.ts:34(nowabcaon PR feat(notifications): preview-deploy screenshot pipeline (provider-agnostic) #241's branch)cli/src/commands/linear.ts:50(still saysbgagent)docs/guides/LINEAR_SETUP_GUIDE.md:89("Default trigger label isbgagent")bgagentappears as the documented defaultSpawned from krokoko's review on PR #241 (item #2, blocking).
Expected behavior
The default trigger label should be one consistent value across processor code, CLI defaults, and documentation. The change should ship in a dedicated PR with a migration note.
Current behavior
PR #241 silently flips the processor default to
abcawhile the CLI and docs still tell users it isbgagent. Any onboarded project whoseLinearProjectMappingTablerow lacks an explicitlabel_filterwould silently switch trigger label on deploy.Proposed solution
Open a separate PR (against
main, not stacked on PR #241) that:DEFAULT_LABEL_FILTERchange inside PR feat(notifications): preview-deploy screenshot pipeline (provider-agnostic) #241's branch (so PR feat(notifications): preview-deploy screenshot pipeline (provider-agnostic) #241 only has the screenshot pipeline)bgagent → abcachange in the new PR with all four sites aligned in a single commitdocs/guides/LINEAR_SETUP_GUIDE.mdand any other doc claimingbgagentis the defaultAcceptance criteria
linear-webhook-processor.tsthat flips the default'bgagent'as a default-label string anywhere in code or docs after the new PR lands