From b4813b6db33785bfdefa62f2bb6babd82cf4aa37 Mon Sep 17 00:00:00 2001 From: Jens Geyer Date: Wed, 16 Sep 2026 22:44:09 +0200 Subject: [PATCH] THRIFT-6265: Drop the backports.ssl_match_hostname dependency Client: py setup.py added backports.ssl_match_hostname to the "ssl" extra when run on a Python older than 3.5. The build requires setuptools 69 or later, which needs Python 3.8, and the library supports Python 3.10 onwards. The branch is therefore never taken, and the extra has been empty in every build. The "ssl" extra itself stays, so that installing thrift[ssl] keeps working. The AppVeyor build no longer installs the package either. Co-Authored-By: Claude Opus 5 (1M context) --- build/appveyor/MSVC-appveyor-full.bat | 3 +-- lib/py/setup.py | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/build/appveyor/MSVC-appveyor-full.bat b/build/appveyor/MSVC-appveyor-full.bat index e0792831341..1b9e285b447 100644 --- a/build/appveyor/MSVC-appveyor-full.bat +++ b/build/appveyor/MSVC-appveyor-full.bat @@ -145,8 +145,7 @@ IF "%WITH_PYTHON%" == "ON" ( "!PYTHON_ROOT!\python.exe" -m ensurepip --upgrade || EXIT /B "!PYTHON_ROOT!\python.exe" -m pip install --upgrade pip setuptools wheel || EXIT /B "!PYTHON_ROOT!\python.exe" -m pip ^ - install backports.ssl_match_hostname ^ - ipaddress ^ + install ipaddress ^ tornado>=6.3.0 ^ twisted>=24.3.0 ^ zope.interface>=6.1 || EXIT /B diff --git a/lib/py/setup.py b/lib/py/setup.py index e8d8d626e02..7997c611977 100644 --- a/lib/py/setup.py +++ b/lib/py/setup.py @@ -104,8 +104,6 @@ def run_setup(with_binary): extensions = dict() ssl_deps = [] - if sys.hexversion < 0x03050000: - ssl_deps.append('backports.ssl_match_hostname>=3.5') tornado_deps = ['tornado>=6.3.0'] twisted_deps = ['twisted>=24.3.0', 'zope.interface>=6.1']