Same single-element create_hashes pattern here, but this one is on the streaming hot path (called once per appended group). Since consecutive append_val calls usually see the same dict_values array, caching the batch's hashes keyed on Arc::as_ptr(dict.values()) would reduce this to one vectorized hash pass per batch. Fine as a follow-up.
Originally posted by @zhuqi-lucas in #23187 (comment)
Same single-element
create_hashespattern here, but this one is on the streaming hot path (called once per appended group). Since consecutiveappend_valcalls usually see the samedict_valuesarray, caching the batch's hashes keyed onArc::as_ptr(dict.values())would reduce this to one vectorized hash pass per batch. Fine as a follow-up.Originally posted by @zhuqi-lucas in #23187 (comment)