Skip to content

Commit dffbc87

Browse files
authored
escapes for injection prtection (#7069)
1 parent 77df050 commit dffbc87

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private String generateSearchFilter(final String username, Long domainId) {
8383
usernameFilter.append("(");
8484
usernameFilter.append(_ldapConfiguration.getUsernameAttribute(domainId));
8585
usernameFilter.append("=");
86-
usernameFilter.append((username == null ? "*" : username));
86+
usernameFilter.append((username == null ? "*" : LdapUtils.escapeLDAPSearchFilter(username)));
8787
usernameFilter.append(")");
8888

8989
String memberOfAttribute = _ldapConfiguration.getUserMemberOfAttribute(domainId);
@@ -154,7 +154,7 @@ private String generateGroupSearchFilter(final String groupName, Long domainId)
154154
groupNameFilter.append("(");
155155
groupNameFilter.append(_ldapConfiguration.getCommonNameAttribute());
156156
groupNameFilter.append("=");
157-
groupNameFilter.append((groupName == null ? "*" : groupName));
157+
groupNameFilter.append((groupName == null ? "*" : LdapUtils.escapeLDAPSearchFilter(groupName)));
158158
groupNameFilter.append(")");
159159

160160
final StringBuilder result = new StringBuilder();
@@ -194,7 +194,7 @@ public LdapUser getUser(final String username, final String type, final String n
194194
usernameFilter.append("(");
195195
usernameFilter.append(_ldapConfiguration.getUsernameAttribute(domainId));
196196
usernameFilter.append("=");
197-
usernameFilter.append((username == null ? "*" : username));
197+
usernameFilter.append((username == null ? "*" : LdapUtils.escapeLDAPSearchFilter(username)));
198198
usernameFilter.append(")");
199199

200200
final StringBuilder memberOfFilter = new StringBuilder();

0 commit comments

Comments
 (0)