Skip to content

Commit c20c84d

Browse files
committed
fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
1 parent a096cf3 commit c20c84d

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎tools/contribution/README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ input when discussing committer or PMC nominations. The numbers are only a
2424
rough signal; read the actual contributions before drawing conclusions.
2525

2626
| Script | Data source | What it counts |
27-
|---|---|---|
27+
| --- | --- | --- |
2828
| `github_org_contributions.py` | GitHub GraphQL API | PRs opened, issues opened and PR reviews per user, in CloudStack repos (by default) of an org |
2929
| `apache_list_mentions.py` | lists.apache.org mbox archives | How often each name (or alias) appears in mailing list message bodies |
3030

@@ -47,7 +47,7 @@ python3 github_org_contributions.py --org apache --users octocat \
4747
```
4848

4949
| Option | Description |
50-
|---|---|
50+
| --- | --- |
5151
| `--org` | GitHub organization login (required) |
5252
| `--users` | One or more GitHub usernames, space separated (required) |
5353
| `--repo-pattern` | Regex matched (case-insensitively) against repo names; only matching repos are counted. Default: `^cloudstack`. Use `.` for all org repos |
@@ -82,14 +82,14 @@ python3 apache_list_mentions.py --list dev --domain cloudstack.apache.org \
8282
```
8383

8484
| Option | Description |
85-
|---|---|
85+
| --- | --- |
8686
| `--list` | List name, e.g. `dev`, `users` (required) |
8787
| `--domain` | List domain, e.g. `cloudstack.apache.org` (required) |
8888
| `--names` | Names file, see below (required) |
8989
| `--months` | Number of months back, including the current one. Default: 12 |
9090
| `--cache-dir` | Where downloaded archives are kept. Default: `~/.cache/apache-list-mentions` |
9191
| `--include-quotes` | Also count lines starting with `>` (quoted replies) |
92-
| `--include-signature` | Also count text after a `-- ` signature separator |
92+
| `--include-signature` | Also count text after the signature separator (a line containing only `--`) |
9393

9494
Names file format, one person per line, results are printed in the same order:
9595

‎tools/contribution/apache_list_mentions.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ def parse_names_file(path: Path) -> Tuple[List[str], Dict[str, List[str]]]:
203203
if ":" in left:
204204
canon, aliases = left.split(":", 1)
205205
canon = canon.strip()
206-
als = [a.strip() for a in aliases.split(",") if a.strip()]
207-
variants = [canon] + [a for a in als if a.lower() != canon.lower()]
206+
alias_list = [a.strip() for a in aliases.split(",") if a.strip()]
207+
variants = [canon] + [a for a in alias_list if a.lower() != canon.lower()]
208208
else:
209209
canon = left
210210
variants = [canon]

0 commit comments

Comments
 (0)