network: address review comments on the egress allowed offering (PR 14286)

Rename the NetworkOfferingVO constructor parameter egressdefaultpolicy to
egressDefaultPolicy to match the field, and log the service instead of the
whole service map entry in the default offering trace messages.

Author: weizhouapache

engine/schema/src/main/java/com/cloud/offerings/NetworkOfferingVO.java

@@ -384,7 +384,7 @@ public NetworkOfferingVO(String name, String displayText, TrafficType trafficTyp
     public NetworkOfferingVO(String name, String displayText, TrafficType trafficType, boolean systemOnly, boolean specifyVlan, Integer rateMbps,
             Integer multicastRateMbps, boolean isDefault, Availability availability, String tags, Network.GuestType guestType, boolean conserveMode, boolean dedicatedLb,
             boolean sharedSourceNat, boolean redundantRouter, boolean elasticIp, boolean elasticLb, boolean specifyIpRanges, boolean inline, boolean isPersistent,
-            boolean associatePublicIP, boolean publicLb, boolean internalLb, boolean isForVpc, boolean egressdefaultpolicy, boolean supportsStrechedL2, boolean supportsPublicAccess) {
+            boolean associatePublicIP, boolean publicLb, boolean internalLb, boolean isForVpc, boolean egressDefaultPolicy, boolean supportsStrechedL2, boolean supportsPublicAccess) {
         this(name,
             displayText,
             trafficType,
@@ -408,7 +408,7 @@ public NetworkOfferingVO(String name, String displayText, TrafficType trafficTyp
         this.elasticLb = elasticLb;
         this.inline = inline;
         this.eipAssociatePublicIp = associatePublicIP;
-        this.egressDefaultPolicy = egressdefaultpolicy;
+        this.egressDefaultPolicy = egressDefaultPolicy;
         this.supportsStrechedL2 = supportsStrechedL2;
         this.supportsPublicAccess = supportsPublicAccess;
     }

server/src/main/java/com/cloud/server/ConfigurationServerImpl.java

@@ -1086,13 +1086,13 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
                             new NetworkOfferingServiceMapVO(defaultIsolatedSourceNatEnabledNetworkOffering.getId(), service,
                                     defaultIsolatedSourceNatEnabledNetworkOfferingProviders.get(service));
                     _ntwkOfferingServiceMapDao.persist(offService);
-                    logger.trace("Added service {} for the network offering: {}", offService, defaultIsolatedSourceNatEnabledNetworkOffering.getUniqueName());
+                    logger.trace("Added service {} for the network offering: {}", service, defaultIsolatedSourceNatEnabledNetworkOffering.getUniqueName());
 
                     offService =
                             new NetworkOfferingServiceMapVO(defaultIsolatedSourceNatEnabledNetworkOfferingWithDefaultEgressAllowed.getId(), service,
                                     defaultIsolatedSourceNatEnabledNetworkOfferingProviders.get(service));
                     _ntwkOfferingServiceMapDao.persist(offService);
-                    logger.trace("Added service {} for the network offering: {}", offService, defaultIsolatedSourceNatEnabledNetworkOfferingWithDefaultEgressAllowed.getUniqueName());
+                    logger.trace("Added service {} for the network offering: {}", service, defaultIsolatedSourceNatEnabledNetworkOfferingWithDefaultEgressAllowed.getUniqueName());
                 }
 
                 // Offering #4