From afd281683b49753cc71d5283171353058a42f327 Mon Sep 17 00:00:00 2001 From: tvalentyn Date: Wed, 22 Jul 2026 10:16:51 -0700 Subject: [PATCH 1/2] Provide better error when beam plugin was supplied but wasn't staged. --- .../apache_beam/runners/worker/sdk_worker_main.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sdks/python/apache_beam/runners/worker/sdk_worker_main.py b/sdks/python/apache_beam/runners/worker/sdk_worker_main.py index 754a631eaf33..e21c423751b8 100644 --- a/sdks/python/apache_beam/runners/worker/sdk_worker_main.py +++ b/sdks/python/apache_beam/runners/worker/sdk_worker_main.py @@ -57,17 +57,21 @@ def _import_beam_plugins(plugins): try: importlib.import_module(plugin) _LOGGER.debug('Imported beam-plugin %s', plugin) - except ImportError: + except ImportError as exc: + if '.' not in plugin: + _LOGGER.warning('Failed to import beam-plugin %s', plugin, exc_info=exc) + continue + try: _LOGGER.debug(( "Looks like %s is not a module. " - "Trying to import it assuming it's a class"), + "Trying to import it assuming it's a class."), plugin) module, _ = plugin.rsplit('.', 1) importlib.import_module(module) _LOGGER.debug('Imported %s for beam-plugin %s', module, plugin) - except ImportError as exc: - _LOGGER.warning('Failed to import beam-plugin %s', plugin, exc_info=exc) + except ImportError as fallback_exc: + _LOGGER.warning('Failed to import beam-plugin %s', plugin, exc_info=fallback_exc) def create_harness(environment, dry_run=False): From 1f06303c9de6c1e7a99365334546352f7b0b81e4 Mon Sep 17 00:00:00 2001 From: tvalentyn Date: Wed, 22 Jul 2026 11:03:27 -0700 Subject: [PATCH 2/2] formatting --- sdks/python/apache_beam/runners/worker/sdk_worker_main.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdks/python/apache_beam/runners/worker/sdk_worker_main.py b/sdks/python/apache_beam/runners/worker/sdk_worker_main.py index e21c423751b8..d3acf6c41dd1 100644 --- a/sdks/python/apache_beam/runners/worker/sdk_worker_main.py +++ b/sdks/python/apache_beam/runners/worker/sdk_worker_main.py @@ -71,7 +71,8 @@ def _import_beam_plugins(plugins): importlib.import_module(module) _LOGGER.debug('Imported %s for beam-plugin %s', module, plugin) except ImportError as fallback_exc: - _LOGGER.warning('Failed to import beam-plugin %s', plugin, exc_info=fallback_exc) + _LOGGER.warning( + 'Failed to import beam-plugin %s', plugin, exc_info=fallback_exc) def create_harness(environment, dry_run=False):