Skip to content

[AAASM-2722] 🔧 (node-sdk): Use canonical lowercase org ID ai-agent-assembly#86

Merged
Chisanan232 merged 3 commits into
masterfrom
v0.0.1/AAASM-2722/lowercase_org_id
Jun 7, 2026
Merged

[AAASM-2722] 🔧 (node-sdk): Use canonical lowercase org ID ai-agent-assembly#86
Chisanan232 merged 3 commits into
masterfrom
v0.0.1/AAASM-2722/lowercase_org_id

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

Target

  • Task summary:

    Lowercase the GitHub org ID AI-agent-assemblyai-agent-assembly across the node-sdk repo so every reference uses the canonical lowercase org slug. The most important change is the aa-sdk-client git-SHA-pin URL in native/aa-ffi-node/Cargo.toml, with native/aa-ffi-node/Cargo.lock updated to match (source URL only; the pinned rev and all crate versions are unchanged).

  • Task tickets:

  • Key point change (optional):

    • native/aa-ffi-node/Cargo.toml: aa-sdk-client git URL host → github.com/ai-agent-assembly/agent-assembly.git.
    • native/aa-ffi-node/Cargo.lock: regenerated source URL lines to match (URL-only; --locked resolves clean, no version churn).
    • .github/workflows/*, .gitmodules, README/docs/*.md, sonar-project.properties, website/docusaurus.config.ts, verification reports: org slug lowercased.

Effecting Scope

  • Action Types:
    • ♻️ Refactoring something
      • 🟢 No breaking change
  • Scopes:
    • 🚀 Building
      • 🤖 CI/CD
      • 🔗 Dependencies
      • 📦 Project configurations
    • 📚 Documentation
  • Additional description:
    No code/behavior change. GitHub treats org slug case-insensitively (the repo has already moved to the lowercase canonical location), so this only normalizes references.

Description

Verified locally:

  • git grep 'AI-agent-assembly' → no matches.
  • cargo metadata --locked resolves clean (pinned rev unchanged, no crate version churn).
  • pnpm install && pnpm build && pnpm test → 179 passed / 2 skipped.
  • pnpm native:buildaa-sdk-client + aa-proto compile from the lowercased git URL.

Closes AAASM-2722.

🤖 Generated with Claude Code

Chisanan232 and others added 3 commits June 7, 2026 21:03
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

sonarqubecloud Bot commented Jun 7, 2026

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

Review — Claude Code

CI: ✅ All green (14 checks): build, napi-build ×2, test ×4, module-smoke ×3, coverage-and-analysis, quality, SonarCloud, codecov/patch.

Scope vs AAASM-2722 (lowercase org ID AI-agent-assemblyai-agent-assembly across node-sdk): ✅ Complete — git grep 'AI-agent-assembly' → 0. The three categories that actually carried the org ID were covered:

  • deps: native/aa-ffi-node/Cargo.toml + Cargo.lock git-dep URL — applied as a case-only sed (not cargo generate-lockfile, which would have churned 132 transitive crates), so the rev pin and all versions are preserved; verified with cargo metadata --locked.
  • ci: workflow URLs (quality-report.yml, release-node.yml).
  • docs/config: .gitmodules, README/CONTRIBUTING/docs, sonar-project.properties, docusaurus.config.ts, verification reports.

Local: pnpm build + pnpm test (179 passed / 2 skipped) + pnpm native:build from the lowercased github.com/ai-agent-assembly/... URL all pass.

Verdict: ✅ Ready for Pioneer approval + merge. No real CI failures; the lockfile change is case-only with no dependency churn.

@Chisanan232 Chisanan232 merged commit 978da67 into master Jun 7, 2026
14 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-2722/lowercase_org_id branch June 7, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant