add horizontal pod auto scale at 80% cpu usage#28
Open
ScottBishop wants to merge 2 commits into
Open
Conversation
kennyko
suggested changes
Dec 12, 2018
kennyko
left a comment
kennyko
left a comment
Contributor
There was a problem hiding this comment.
Ideally the service should be able to safely scale up and down before introducing an autoscaler. Make sure the application can handle terminations without causing errors. (like if the pod is killed while processing an image, it won't be killed until its done) https://kubernetes.io/docs/concepts/workloads/pods/pod/#termination-of-pods
| @@ -0,0 +1,17 @@ | |||
| apiVersion: autoscaling/v1 | |||
Contributor
There was a problem hiding this comment.
not everyone may want to use an HPA, so wrap all of this in an if?
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| name: {{ .Chart.Name }} | ||
| targetCPUUtilizationPercentage: 80 No newline at end of file |
| maxReplicas: {{ .Values.maxReplica }} | ||
| minReplicas: {{ .Values.replicaCount }} | ||
| scaleTargetRef: | ||
| apiVersion: apps/v1 |
Contributor
There was a problem hiding this comment.
update the apiVersion in deployment.yaml
…, update deployment apiVersion
kennyko
approved these changes
Dec 13, 2018
ScottBishop
added
Ready To Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.