fix(knng): fix recall calculation for the knng example

Author: Neiko2002

cpp/bench/CMakeLists.txt

@@ -11,10 +11,10 @@ endif()
 
 add_executable(bench_static_data ${PROJECT_SOURCE_DIR}/src/bench_static_data.cpp)
 target_include_directories(bench_static_data PRIVATE ${PROJECT_SOURCE_DIR}/include)
-target_link_libraries(bench_static_data PUBLIC DEG_LIB compile-options fmt::fmt-header-only)
+target_link_libraries(bench_static_data PUBLIC DEG_LIB compile-options fmt::fmt)
 target_compile_definitions(bench_static_data PUBLIC "DATA_PATH=\"${DATA_PATH}\"")
 
 add_executable(bench_dynamic_data ${PROJECT_SOURCE_DIR}/src/bench_dynamic_data.cpp)
 target_include_directories(bench_dynamic_data PRIVATE ${PROJECT_SOURCE_DIR}/include)
-target_link_libraries(bench_dynamic_data PUBLIC DEG_LIB compile-options fmt::fmt-header-only)
+target_link_libraries(bench_dynamic_data PUBLIC DEG_LIB compile-options fmt::fmt)
 target_compile_definitions(bench_dynamic_data PUBLIC "DATA_PATH=\"${DATA_PATH}\"")

cpp/deglib/include/deglib/graph/sizebounded_graph.h

@@ -732,7 +732,7 @@ class SizeBoundedGraph : public deglib::graph::MutableGraph {
 /**
  * Load the graph
  */
-auto load_sizebounded_graph(const char* path_graph, uint32_t new_max_size = 0)
+inline auto load_sizebounded_graph(const char* path_graph, uint32_t new_max_size = 0)
 {
   std::error_code ec{};
   auto file_size = std::filesystem::file_size(path_graph, ec);

examples/knng/main.py

@@ -26,17 +26,15 @@
 from deglib.distances import FloatSpace, Metric, quantize_batch
 from dataset_utils import load_hdf5_dataset, ensure_small_dataset, DEFAULT_CACHE_DIR
 
-
 DEFAULT_K_TOP = 15
-DEFAULT_K_GRAPH = 18
-DEFAULT_K_EXT = 41
-DEFAULT_NON_ZEROS = 768
-DEFAULT_MAX_DIST = 586
-DEFAULT_EVP_K = 78
-DEFAULT_PRUNE_WORST = 9
+DEFAULT_K_GRAPH = 16
+DEFAULT_K_EXT = 32
+DEFAULT_NON_ZEROS = 700
+DEFAULT_MAX_DIST = 400
+DEFAULT_EVP_K = 50
+DEFAULT_PRUNE_WORST = 6
 DEFAULT_THREADS = 8
 
-
 def prune_worst_edges(graph: deglib.DynamicExplorationGraph, prune_worst: int) -> None:
     """
     Prunes the worst (highest-weight) `prune_worst` neighbors of each vertex
@@ -73,9 +71,6 @@ def construct_knng(
     Constructs and evaluates a k-Nearest Neighbor Graph (k-NNG) using DEG.
     """
     n_vecs, dims = train_vectors.shape
-    if train_vectors.dtype == np.float16:
-        train_vectors = train_vectors.view(np.uint16)
-
     print(f"Dataset shape: {n_vecs} vectors, {dims} dimensions (dtype: {train_vectors.dtype})")
     print(f"k-NNG Construction Config: k_top={k_top}, k_graph={k_graph}, non_zeros={non_zeros}, max_dist={max_dist}, evp_k={evp_k}, prune_worst={prune_worst}, threads={threads}")
 
@@ -142,7 +137,9 @@ def construct_knng(
         correct = 0
         total_gt = 0
         for i in range(n_vecs):
-            gt_set = set(ground_truth[i, :k_top])
+            # Ground truth list clean-up: remove self-references (i) if present
+            gt_row = [idx for idx in ground_truth[i] if idx != i][:k_top]
+            gt_set = set(gt_row)
             pred_set = set(final_knng_edges[i])
             correct += len(gt_set.intersection(pred_set))
             total_gt += len(gt_set)