From ea7da0768f11de7333211e2a194234bce93e4080 Mon Sep 17 00:00:00 2001
From: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Date: Wed, 24 Sep 2025 10:39:15 -0700
Subject: [PATCH 1/3] Fix all packages for noUncheckedSideEffectImports
(#73738)
---
attw.json | 1 -
types/chai-arrays/chai-arrays-tests.ts | 3 ++-
types/chai-fs/chai-fs-tests.ts | 3 ++-
types/chai-json-schema/chai-json-schema-tests.ts | 3 ++-
types/chai-like/chai-like-tests.ts | 3 ++-
types/chai-spies/chai-spies-tests.ts | 2 +-
types/chai-string/chai-string-tests.ts | 3 ++-
types/dirty-chai/dirty-chai-tests.ts | 4 ++--
types/hapi/test/server/server-events.ts | 1 -
types/hapi/v17/test/server/server-events.ts | 1 -
types/karma-chai/index.d.ts | 10 ++++------
types/karma-chai/karma-chai-tests.ts | 8 ++------
types/node/v18/node-tests.ts | 1 -
types/page-flip/dist/PageFlip.d.ts | 1 -
types/rangy/rangy-tests.ts | 5 -----
types/react-katex/react-katex-tests.tsx | 1 -
types/react-smartbanner/react-smartbanner-tests.tsx | 1 -
types/redux-shortcuts/index.d.ts | 1 -
types/splitting/splitting-tests.ts | 2 --
types/tablesorter/test/Methods.ts | 1 -
types/vue-moment/vue-moment-tests.ts | 1 -
types/vue3-carousel-3d/vue3-carousel-3d-tests.ts | 1 -
types/wonder.js/index.d.ts | 1 -
23 files changed, 19 insertions(+), 39 deletions(-)
diff --git a/attw.json b/attw.json
index 88acbe94283b28..a7d460c42470ea 100644
--- a/attw.json
+++ b/attw.json
@@ -199,7 +199,6 @@
"opencc-js",
"opentok",
"osmtogeojson",
- "page-flip",
"pako",
"parse-listing",
"parse/v1",
diff --git a/types/chai-arrays/chai-arrays-tests.ts b/types/chai-arrays/chai-arrays-tests.ts
index bbc880b85182f9..964c0d75308ab8 100644
--- a/types/chai-arrays/chai-arrays-tests.ts
+++ b/types/chai-arrays/chai-arrays-tests.ts
@@ -1,5 +1,6 @@
+///
+
import ChaiArrays = require("chai-arrays");
-import "chai/register-should";
declare const assert: Chai.AssertStatic;
declare const expect: Chai.ExpectStatic;
diff --git a/types/chai-fs/chai-fs-tests.ts b/types/chai-fs/chai-fs-tests.ts
index b99f2766d2b8b5..3e8a90f0e1f206 100644
--- a/types/chai-fs/chai-fs-tests.ts
+++ b/types/chai-fs/chai-fs-tests.ts
@@ -1,5 +1,6 @@
+///
+
import Chaifs = require("chai-fs");
-import "chai/register-should";
declare const assert: Chai.AssertStatic;
declare const expect: Chai.ExpectStatic;
diff --git a/types/chai-json-schema/chai-json-schema-tests.ts b/types/chai-json-schema/chai-json-schema-tests.ts
index 232a9c2dc7fa6b..0dc2bca10c3e32 100644
--- a/types/chai-json-schema/chai-json-schema-tests.ts
+++ b/types/chai-json-schema/chai-json-schema-tests.ts
@@ -1,6 +1,7 @@
+///
+
import ChaiJsonSchema = require("chai-json-schema");
import { TV4 } from "tv4";
-import "chai/register-should";
declare const assert: Chai.AssertStatic;
declare const expect: Chai.ExpectStatic;
diff --git a/types/chai-like/chai-like-tests.ts b/types/chai-like/chai-like-tests.ts
index 17823101dedc97..1b4442deb9f420 100644
--- a/types/chai-like/chai-like-tests.ts
+++ b/types/chai-like/chai-like-tests.ts
@@ -1,5 +1,6 @@
+///
+
import chaiLike = require("chai-like");
-import "chai/register-should";
declare const expect: Chai.ExpectStatic;
diff --git a/types/chai-spies/chai-spies-tests.ts b/types/chai-spies/chai-spies-tests.ts
index 2859a3a3be88f0..8ead3d8a330643 100644
--- a/types/chai-spies/chai-spies-tests.ts
+++ b/types/chai-spies/chai-spies-tests.ts
@@ -1,5 +1,5 @@
+///
import spies = require("chai-spies");
-import "chai/register-should";
import("chai").then(({ use }) => {
const chai = use(spies);
diff --git a/types/chai-string/chai-string-tests.ts b/types/chai-string/chai-string-tests.ts
index 99e7ed9dc3475d..0a491fc5bd61f3 100644
--- a/types/chai-string/chai-string-tests.ts
+++ b/types/chai-string/chai-string-tests.ts
@@ -1,9 +1,10 @@
+///
+
declare const assert: Chai.AssertStatic;
declare const expect: Chai.ExpectStatic;
import chai_string = require("chai-string");
import("chai").then(({ use }) => use(chai_string));
-import "chai/register-should";
// Stub mocha functions
const { describe, it, before, after, beforeEach, afterEach } = null as any as {
diff --git a/types/dirty-chai/dirty-chai-tests.ts b/types/dirty-chai/dirty-chai-tests.ts
index 969ab2a48ca9c7..ae48a8636134a3 100644
--- a/types/dirty-chai/dirty-chai-tests.ts
+++ b/types/dirty-chai/dirty-chai-tests.ts
@@ -1,11 +1,11 @@
+///
+
import chaiAsPromised = require("chai-as-promised");
import("chai").then(chai => chai.use(chaiAsPromised));
import dirtyChai = require("dirty-chai");
import("chai").then(chai => chai.use(dirtyChai));
-import "chai/register-should";
-
declare const expect: Chai.ExpectStatic;
// mocha-like stubs so we don't need to use mocha typings
diff --git a/types/hapi/test/server/server-events.ts b/types/hapi/test/server/server-events.ts
index 4091cdac4ba4a4..0e1e9c58b60111 100644
--- a/types/hapi/test/server/server-events.ts
+++ b/types/hapi/test/server/server-events.ts
@@ -1,7 +1,6 @@
// https://github.com/hapijs/hapi/blob/master/API.md#-servereventevents
import { Server, ServerEvents } from "hapi";
import Podium = require("podium");
-import "hapi/definitions/server/server";
declare module "hapi" {
interface ServerEvents {
diff --git a/types/hapi/v17/test/server/server-events.ts b/types/hapi/v17/test/server/server-events.ts
index 4091cdac4ba4a4..0e1e9c58b60111 100644
--- a/types/hapi/v17/test/server/server-events.ts
+++ b/types/hapi/v17/test/server/server-events.ts
@@ -1,7 +1,6 @@
// https://github.com/hapijs/hapi/blob/master/API.md#-servereventevents
import { Server, ServerEvents } from "hapi";
import Podium = require("podium");
-import "hapi/definitions/server/server";
declare module "hapi" {
interface ServerEvents {
diff --git a/types/karma-chai/index.d.ts b/types/karma-chai/index.d.ts
index e5892c74bfd023..515d9b233640ff 100644
--- a/types/karma-chai/index.d.ts
+++ b/types/karma-chai/index.d.ts
@@ -1,7 +1,5 @@
-import "chai";
+///
-declare global {
- var assert: Chai.AssertStatic;
- var expect: Chai.ExpectStatic;
- var should: Chai.Should;
-}
+declare var assert: Chai.AssertStatic;
+declare var expect: Chai.ExpectStatic;
+declare var should: Chai.Should;
diff --git a/types/karma-chai/karma-chai-tests.ts b/types/karma-chai/karma-chai-tests.ts
index 28a7940d5b7c39..ee41d3277747e3 100644
--- a/types/karma-chai/karma-chai-tests.ts
+++ b/types/karma-chai/karma-chai-tests.ts
@@ -1,9 +1,5 @@
-///
-import "chai/register-should";
+///
-declare const expect: Chai.ExpectStatic;
-declare const assert: Chai.AssertStatic;
-
-true.should.be.ok;
expect(true).to.be.ok;
assert.isTrue(true);
+should.equal(true, true);
diff --git a/types/node/v18/node-tests.ts b/types/node/v18/node-tests.ts
index f5587dc84e316c..2916ccb4836399 100644
--- a/types/node/v18/node-tests.ts
+++ b/types/node/v18/node-tests.ts
@@ -9,7 +9,6 @@ import "./test/crypto";
import "./test/dgram";
import "./test/diagnostics_channel";
import "./test/dns";
-import "./test/dom-events"; // dom-events behaves differently under lib-dom
import "./test/events";
import "./test/events_generic";
import "./test/fs";
diff --git a/types/page-flip/dist/PageFlip.d.ts b/types/page-flip/dist/PageFlip.d.ts
index 76ce0b0b91630d..1c1aa7e0356d1b 100644
--- a/types/page-flip/dist/PageFlip.d.ts
+++ b/types/page-flip/dist/PageFlip.d.ts
@@ -6,7 +6,6 @@ import { Page } from "./Page/Page";
import { Orientation, Render } from "./Render/Render";
import { FlipSetting } from "./Settings";
import { UI } from "./UI/UI";
-import "./Style/stPageFlip.css";
/**
* Class representing a main PageFlip object
*/
diff --git a/types/rangy/rangy-tests.ts b/types/rangy/rangy-tests.ts
index 4656ae64b67c7d..0347f10b6634a9 100644
--- a/types/rangy/rangy-tests.ts
+++ b/types/rangy/rangy-tests.ts
@@ -1,9 +1,4 @@
import * as rangy from "rangy";
-import "rangy/lib/rangy-classapplier";
-import "rangy/lib/rangy-highlighter";
-import "rangy/lib/rangy-selectionsaverestore";
-import "rangy/lib/rangy-serializer";
-import "rangy/lib/rangy-textrange";
declare function assertAny(a: any): any;
declare function assertBoolean(b: boolean): any;
diff --git a/types/react-katex/react-katex-tests.tsx b/types/react-katex/react-katex-tests.tsx
index d43df7006f31a4..81c5e5238f3918 100644
--- a/types/react-katex/react-katex-tests.tsx
+++ b/types/react-katex/react-katex-tests.tsx
@@ -1,4 +1,3 @@
-import "katex/dist/katex.min.css";
import * as React from "react";
import { BlockMath, InlineMath } from "react-katex";
diff --git a/types/react-smartbanner/react-smartbanner-tests.tsx b/types/react-smartbanner/react-smartbanner-tests.tsx
index a315ff04222b10..a707f752d95f68 100644
--- a/types/react-smartbanner/react-smartbanner-tests.tsx
+++ b/types/react-smartbanner/react-smartbanner-tests.tsx
@@ -1,6 +1,5 @@
import React from "react";
import SmartBanner from "react-smartbanner";
-import "react-smartbanner/dist/main.css";
const EmptySmartBanner: React.FC = () => {
// @ts-expect-error required parameter 'position' is missing
diff --git a/types/redux-shortcuts/index.d.ts b/types/redux-shortcuts/index.d.ts
index a062e47986a1e4..494a81b2f87721 100644
--- a/types/redux-shortcuts/index.d.ts
+++ b/types/redux-shortcuts/index.d.ts
@@ -1,6 +1,5 @@
import { Action, ActionCreator, Dispatch } from "redux";
import Mousetrap = require("mousetrap");
-import "mousetrap/extensions/global";
export { Mousetrap };
export const mousetrap: Mousetrap.MousetrapInstance;
diff --git a/types/splitting/splitting-tests.ts b/types/splitting/splitting-tests.ts
index 1caa307e9f5fec..3a42cc6860c281 100644
--- a/types/splitting/splitting-tests.ts
+++ b/types/splitting/splitting-tests.ts
@@ -1,6 +1,4 @@
import Splitting = require("splitting");
-import "splitting/dist/splitting.css";
-import "splitting/dist/splitting-cells.css";
// Base splitting function
diff --git a/types/tablesorter/test/Methods.ts b/types/tablesorter/test/Methods.ts
index e65bd8cacfd037..b1bf36b715f5ad 100644
--- a/types/tablesorter/test/Methods.ts
+++ b/types/tablesorter/test/Methods.ts
@@ -1,4 +1,3 @@
-import "./Tests";
import {
ParsedCell,
Parser,
diff --git a/types/vue-moment/vue-moment-tests.ts b/types/vue-moment/vue-moment-tests.ts
index e0794e77c9bc84..a41899740938db 100644
--- a/types/vue-moment/vue-moment-tests.ts
+++ b/types/vue-moment/vue-moment-tests.ts
@@ -1,5 +1,4 @@
import moment from "moment";
-import "moment/locale/de";
import Vue from "vue";
import VueMoment from "vue-moment";
diff --git a/types/vue3-carousel-3d/vue3-carousel-3d-tests.ts b/types/vue3-carousel-3d/vue3-carousel-3d-tests.ts
index ce22295b9be764..3f82d55606bb8e 100644
--- a/types/vue3-carousel-3d/vue3-carousel-3d-tests.ts
+++ b/types/vue3-carousel-3d/vue3-carousel-3d-tests.ts
@@ -1,6 +1,5 @@
import { createApp } from "vue";
import { Carousel3d, Slide } from "vue3-carousel-3d";
-import "vue3-carousel-3d/dist/index.css";
createApp({
components: {
diff --git a/types/wonder.js/index.d.ts b/types/wonder.js/index.d.ts
index 906934c485a83f..0816d30c7c83f6 100644
--- a/types/wonder.js/index.d.ts
+++ b/types/wonder.js/index.d.ts
@@ -553,7 +553,6 @@ declare module "wonder.js/dist/es2015/core/Component" {
declare module "wonder.js/dist/es2015/core/Director" {
import "wonder-frp/dist/es2015/stream/ConcatStream";
import "wonder-frp/dist/es2015/stream/IgnoreElementsStream";
- import "wonder-frp/dist/es2015/extend/root";
import { SceneDispatcher } from "wonder.js/dist/es2015/core/entityObject/scene/SceneDispatcher";
import { Renderer } from "wonder.js/dist/es2015/renderer/renderer/Renderer";
export class Director {
From 1341197acdadafc49ba361b98a6111bdee62717b Mon Sep 17 00:00:00 2001
From: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Date: Wed, 24 Sep 2025 11:18:40 -0700
Subject: [PATCH 2/3] Fix more noUncheckedSideEffectImports issues (#73740)
---
types/babel-types/babel-types-tests.ts | 1 -
types/bmapgl-browser/bmapgl-browser-tests.ts | 2 --
types/chai-subset/chai-subset-tests.ts | 2 +-
types/gun/gun-tests.ts | 9 ---------
4 files changed, 1 insertion(+), 13 deletions(-)
diff --git a/types/babel-types/babel-types-tests.ts b/types/babel-types/babel-types-tests.ts
index 669469da188dd9..e7e82446f01ae2 100644
--- a/types/babel-types/babel-types-tests.ts
+++ b/types/babel-types/babel-types-tests.ts
@@ -1,4 +1,3 @@
-import "./ts3.6/babel-types-tests";
import traverse from "babel-traverse";
import * as t from "babel-types";
diff --git a/types/bmapgl-browser/bmapgl-browser-tests.ts b/types/bmapgl-browser/bmapgl-browser-tests.ts
index a4c4a63175c4b7..d23675e37143f1 100644
--- a/types/bmapgl-browser/bmapgl-browser-tests.ts
+++ b/types/bmapgl-browser/bmapgl-browser-tests.ts
@@ -1,5 +1,3 @@
-import "bmapgl";
-
class TestFixture {
// document: http://lbsyun.baidu.com/index.php?title=jspopularGL
createMap(container: string | HTMLElement) {
diff --git a/types/chai-subset/chai-subset-tests.ts b/types/chai-subset/chai-subset-tests.ts
index 91f0a3cd22035d..54988b1ba2d37d 100644
--- a/types/chai-subset/chai-subset-tests.ts
+++ b/types/chai-subset/chai-subset-tests.ts
@@ -1,7 +1,7 @@
import chaiSubset = require("chai-subset");
import("chai").then(({ use }) => use(chaiSubset));
-import "chai/register-should";
+
declare const assert: Chai.AssertStatic;
declare const expect: Chai.ExpectStatic;
diff --git a/types/gun/gun-tests.ts b/types/gun/gun-tests.ts
index 4f8390a7d5dc59..fd47ca3a6716bc 100644
--- a/types/gun/gun-tests.ts
+++ b/types/gun/gun-tests.ts
@@ -1,14 +1,5 @@
import GunServer = require("gun");
import Gun = require("gun/gun");
-import "gun/lib/path.js";
-import "gun/lib/not.js";
-import "gun/lib/open.js";
-import "gun/lib/load.js";
-import "gun/lib/then.js";
-import "gun/lib/bye.js";
-import "gun/lib/later.js";
-import "gun/lib/unset.js";
-import "gun/lib/time.js";
GunServer("http://yourdomain.com/gun");
Gun(["http://server1.com/gun", "http://server2.com/gun"]);
From bbda17ad85b9d6f28126751260c63232ce04766d Mon Sep 17 00:00:00 2001
From: Elizabeth Samuel
Date: Wed, 24 Sep 2025 13:55:42 -0700
Subject: [PATCH 3/3] [office-js] [office-js-preview] (PowerPoint) Fix typo in
link (#73741)
---
types/office-js-preview/index.d.ts | 2 +-
types/office-js/index.d.ts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/types/office-js-preview/index.d.ts b/types/office-js-preview/index.d.ts
index 63d14bc5989e41..3d243bea5f4592 100644
--- a/types/office-js-preview/index.d.ts
+++ b/types/office-js-preview/index.d.ts
@@ -190066,7 +190066,7 @@ declare namespace PowerPoint {
*/
text?: string;
/**
- * Specifies the contents of the table cell as an array of {@link TextRun} objects.
+ * Specifies the contents of the table cell as an array of {@link PowerPoint.TextRun} objects.
Each `TextRun` object represents a sequence of one or more characters that share the same font attributes.
*
* @remarks
diff --git a/types/office-js/index.d.ts b/types/office-js/index.d.ts
index 353918d0019f78..bdcdaa61d8dbb2 100644
--- a/types/office-js/index.d.ts
+++ b/types/office-js/index.d.ts
@@ -132128,7 +132128,7 @@ declare namespace PowerPoint {
*/
text?: string;
/**
- * Specifies the contents of the table cell as an array of {@link TextRun} objects.
+ * Specifies the contents of the table cell as an array of {@link PowerPoint.TextRun} objects.
Each `TextRun` object represents a sequence of one or more characters that share the same font attributes.
*
* @remarks