Skip to content

query: delete the caller-less CodeLexicalProjectionAdapterV1::new_published and share projection metadata by Arc #1102

Description

@ScriptedAlchemy

Follow-up from #1045 (bf17a7c). After search-eval moved to one-pass scoped partitioning through new_admitted:

  • CodeLexicalProjectionAdapterV1::new_published (in tracedecay-query) has no production caller; only crates/tracedecay-query/tests/search_quality_suite still uses it. Delete it and point the suite at new_admitted (or make new_published the single shared-source constructor and delete the other — one constructor, not two).
  • CodeLexicalProjectionMetadataV1 is still cloned once per scope set because the adapter owns it by value. Let new_admitted take impl Into<Arc<…>> (metadata and the qualified-names map) so search-eval's per-scope adapters share one immutable copy.

Both must keep the packaged search-quality digests (WORKLOAD_SHA256, report_tests pins) unchanged. Prove with cargo test -p tracedecay-query --all-targets and cargo test -p tracedecay-search-eval --all-targets.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions