[codex] Route runtime errors to main bot#141
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5686a1ad97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| crisis_alert_channels=split_env_list(os.getenv("CRISIS_ALERT_CHANNELS")), | ||
| crisis_alert_email_recipients=split_env_list( | ||
| os.getenv("CRISIS_ALERT_EMAIL_RECIPIENTS") | ||
| strategy_plugin_alert_channels=split_env_list(os.getenv("STRATEGY_PLUGIN_ALERT_CHANNELS")), |
There was a problem hiding this comment.
Preserve legacy alert settings during the rename
When a deployed service, or the Cloud Run env-sync workflow before repository vars/secrets are manually renamed, still has the previous CRISIS_ALERT_* settings, this loader now ignores them and returns empty strategy-plugin alert configuration because it only reads STRATEGY_PLUGIN_ALERT_*. Since the workflow also removes the old Cloud Run names, existing alert channels/tokens/chat IDs are silently dropped on the first deploy; keeping a fallback to the old env names during the migration would prevent strategy-plugin alert delivery from being disabled.
Useful? React with 👍 / 👎.
Summary
Validation