Fixes

Author: ianthomas23

docs/conf.py

@@ -1,8 +1,8 @@
-from datetime import date
+from datetime import UTC, datetime
 
 project = "git2cpp"
 author = "QuantStack"
-copyright = f"2025-{date.today().year}"
+copyright = f"2025-{datetime.now(UTC).year}"
 
 extensions = [
     "myst_parser",

pyproject.toml

@@ -2,5 +2,11 @@
 [tool.ruff]
 line-length = 100
 target-version = "py312"
+
 [tool.ruff.format]
 line-ending = "lf"
+
+[tool.ruff.lint]
+ignore = [
+    "PLW1510"
+]

test/conftest_wasm.py

@@ -101,7 +101,7 @@ def read_text(self) -> str:
     def write_bytes(self, data: bytes):
         # Convert binary data to a string where each element is backslash-escaped so that we can
         # write to file in cockle using `echo -e <backslash-escaped data>`.
-        encoded_string = "".join(map(lambda d: f"\\x{d:02x}", data))
+        encoded_string = "".join(lambda d: f"\\x{d:02x}", data)
         cmd = ["echo", "-e", encoded_string, ">", str(self)]
         subprocess.run(cmd, capture_output=True, text=True, check=True)
         return len(data)

test/test_clone.py

@@ -79,7 +79,7 @@ def test_clone_private_repo_fails_then_succeeds(
     # Fails with wrong credentials, then succeeds with correct ones.
     username = "xyz"  # Can be any non-empty string.
     password = private_test_repo["token"]
-    input = "\n".join(["wrong1", "wrong2", username, password]) + "\n"
+    input = f"wrong1\nwrong2\n{username}\n{password}"
     repo_path = tmp_path / private_test_repo["repo_name"]
 
     clone_cmd = [git2cpp_path, "clone", private_test_repo["https_url"]]

test/test_init.py

@@ -12,7 +12,7 @@ def test_init_in_directory(git2cpp_path, tmp_path):
     assert p.stdout.startswith("Initialized empty Git repository in ")
     assert p.stdout.strip().endswith("/")
 
-    assert sorted(map(lambda path: path.name, tmp_path.iterdir())) == [
+    assert sorted(path.name for path in tmp_path.iterdir()) == [
         "HEAD",
         "config",
         "description",
@@ -36,7 +36,7 @@ def test_init_in_cwd(git2cpp_path, tmp_path, run_in_tmp_path):
     assert p.stdout.startswith("Initialized empty Git repository in ")
     assert p.stdout.strip().endswith("/")
 
-    assert sorted(map(lambda path: path.name, tmp_path.iterdir())) == [
+    assert sorted(path.name for path in tmp_path.iterdir()) == [
         "HEAD",
         "config",
         "description",
@@ -60,9 +60,9 @@ def test_init_not_bare(git2cpp_path, tmp_path):
     assert p.stdout.strip().endswith(".git/")
 
     # Directory contains just .git directory.
-    assert sorted(map(lambda path: path.name, tmp_path.iterdir())) == [".git"]
+    assert sorted(path.name for path in tmp_path.iterdir()) == [".git"]
     # .git directory is a valid repo.
-    assert sorted(map(lambda path: path.name, (tmp_path / ".git").iterdir())) == [
+    assert sorted(path.name for path in (tmp_path / ".git").iterdir()) == [
         "HEAD",
         "config",
         "description",

test/test_log.py

@@ -256,7 +256,7 @@ def test_log_commit_without_references(commit_env_config, git2cpp_path, tmp_path
 
     # First commit line should have references
     lines = strip_ansi_colours(p_log.stdout).split("\n")
-    first_commit_line = [line for line in lines if line.startswith("commit")][0]
+    first_commit_line = next(line for line in lines if line.startswith("commit"))
     assert "(" in first_commit_line  # Has references
 
     # Second commit (older one) should not have empty parentheses

test/test_remote.py

@@ -297,7 +297,7 @@ def repo_with_remote(git2cpp_path, tmp_path, run_in_tmp_path):
 
 def test_fetch_from_remote(git2cpp_path, repo_with_remote):
     """Test fetching from a remote."""
-    local_path, remote_path = repo_with_remote
+    local_path, _remote_path = repo_with_remote
 
     # Note: This is a bare repo with no refs, so fetch will fail gracefully
     # For now, just test that  /stdofetch command runs (it will fail gracefully if no refs)
@@ -309,7 +309,7 @@ def test_fetch_from_remote(git2cpp_path, repo_with_remote):
 
 def test_fetch_default_origin(git2cpp_path, repo_with_remote):
     """Test fetching with default origin."""
-    local_path, remote_path = repo_with_remote
+    local_path, _remote_path = repo_with_remote
 
     cmd = [git2cpp_path, "fetch"]
     p = subprocess.run(cmd, capture_output=True, text=True, cwd=local_path)

wasm/recipe/modify-recipe.py

@@ -3,6 +3,7 @@
 
 import argparse
 import shutil
+import sys
 from pathlib import Path
 
 import yaml
@@ -14,11 +15,11 @@
 
 input_dir = args.input_directory
 if not input_dir.is_dir():
-    quit(f"{input_dir} should exist and be a directory")
+    sys.exit(f"{input_dir} should exist and be a directory")
 
 input_filename = input_dir / "recipe.yaml"
 if not input_filename.is_file():
-    quit(f"{input_filename} should exist and be a file")
+    sys.exit(f"{input_filename} should exist and be a file")
 
 # If backup does not exist create it.
 input_backup = input_dir / "recipe_original.yaml"