Skip to content

Commit 2357cae

Browse files
mmckyclaude
andcommitted
ci(publish): drop publish-gh-pages' cname input
The GitHub Actions Pages deploy that publish-gh-pages uses ignores a CNAME file, so the input never set the custom domain: Settings → Pages does, and it already holds python-programming.quantecon.org. From QuantEcon/actions v0.12.0 the action warns on every deploy that still passes it (QuantEcon/actions#109, QuantEcon/actions#110). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent b0b0b56 commit 2357cae

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎.github/workflows/publish.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@ jobs:
122122
uses: quantecon/actions/publish-gh-pages@v0.11.1
123123
with:
124124
build-dir: _build/html
125-
cname: python-programming.quantecon.org
125+
# Custom domain (python-programming.quantecon.org): set in Settings → Pages. The Actions Pages
126+
# deploy ignores a CNAME file, so publish-gh-pages' cname input has no effect.
126127
create-release-assets: 'true'
127128
asset-name: 'lecture-python-programming-html'
128129
github-token: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)