From 023b7f06e354c3556e3f9e74071f44c163e4f79c Mon Sep 17 00:00:00 2001 From: PurHur Date: Sun, 5 Jul 2026 10:56:44 +0000 Subject: [PATCH] chore: drop stale maintainer_gap repros for closed issues (jul05 wave22) Remove seven filing scripts for issues closed today (#16316, #16329, #16346, #16357, #16383, #16408) now guarded by compliance/unit tests; inline #16383 VM check in DateTimeCreateFromFormatTest. Co-authored-by: Cursor --- ...r_gap_array_search_strict_scalar_order.php | 18 --------- ...datetime_createfromformat_time_default.php | 27 -------------- ...aintainer_gap_getimagesize_read_notice.php | 22 ----------- ...ttp_response_headers_phantom_reference.php | 22 ----------- ...er_gap_profile_phantom_function_exists.php | 19 ---------- ..._context_set_options_phantom_reference.php | 19 ---------- ...ner_gap_stream_supports_string_feature.php | 16 -------- test/unit/DateTimeCreateFromFormatTest.php | 37 ++++++++++++------- 8 files changed, 23 insertions(+), 157 deletions(-) delete mode 100644 test/repro/maintainer_gap_array_search_strict_scalar_order.php delete mode 100644 test/repro/maintainer_gap_datetime_createfromformat_time_default.php delete mode 100644 test/repro/maintainer_gap_getimagesize_read_notice.php delete mode 100644 test/repro/maintainer_gap_http_response_headers_phantom_reference.php delete mode 100644 test/repro/maintainer_gap_profile_phantom_function_exists.php delete mode 100644 test/repro/maintainer_gap_stream_context_set_options_phantom_reference.php delete mode 100644 test/repro/maintainer_gap_stream_supports_string_feature.php diff --git a/test/repro/maintainer_gap_array_search_strict_scalar_order.php b/test/repro/maintainer_gap_array_search_strict_scalar_order.php deleted file mode 100644 index 7a477bdf14..0000000000 --- a/test/repro/maintainer_gap_array_search_strict_scalar_order.php +++ /dev/null @@ -1,18 +0,0 @@ -format('Y-m-d')) { - fwrite(STDERR, 'date rollover mismatch: '.$dt->format('Y-m-d')."\n"); - exit(1); -} -if ($dt->format('H:i:s') !== date('H:i:s')) { - fwrite(STDERR, 'time default mismatch: '.$dt->format('H:i:s').' vs '.date('H:i:s')."\n"); - exit(1); -} - -$partial = DateTime::createFromFormat('Y-m-d H', '2020-01-01 14'); -if ('14:00:00' !== $partial->format('H:i:s')) { - fwrite(STDERR, 'partial time mismatch: '.$partial->format('H:i:s')."\n"); - exit(1); -} - -echo "ok\n"; diff --git a/test/repro/maintainer_gap_getimagesize_read_notice.php b/test/repro/maintainer_gap_getimagesize_read_notice.php deleted file mode 100644 index 1468f06c5e..0000000000 --- a/test/repro/maintainer_gap_getimagesize_read_notice.php +++ /dev/null @@ -1,22 +0,0 @@ - function_exists($fn) -); -if ([] !== $bad) { - echo 'fail: advertised '.implode(',', $bad)."\n"; - exit(1); -} - -if (!\is_array(http_get_last_response_headers())) { - echo "fail: not callable\n"; - exit(1); -} - -echo "ok\n"; diff --git a/test/repro/maintainer_gap_profile_phantom_function_exists.php b/test/repro/maintainer_gap_profile_phantom_function_exists.php deleted file mode 100644 index e5af259f76..0000000000 --- a/test/repro/maintainer_gap_profile_phantom_function_exists.php +++ /dev/null @@ -1,19 +0,0 @@ - function_exists($fn)); -if ([] !== $advertised) { - echo 'fail: advertised '.implode(',', $advertised)."\n"; - exit(1); -} - -echo "ok\n"; diff --git a/test/repro/maintainer_gap_stream_context_set_options_phantom_reference.php b/test/repro/maintainer_gap_stream_context_set_options_phantom_reference.php deleted file mode 100644 index 73cadce88c..0000000000 --- a/test/repro/maintainer_gap_stream_context_set_options_phantom_reference.php +++ /dev/null @@ -1,19 +0,0 @@ - ['timeout' => 1]])) { - echo "fail: not callable\n"; - exit(1); -} - -echo "ok\n"; diff --git a/test/repro/maintainer_gap_stream_supports_string_feature.php b/test/repro/maintainer_gap_stream_supports_string_feature.php deleted file mode 100644 index 950710700d..0000000000 --- a/test/repro/maintainer_gap_stream_supports_string_feature.php +++ /dev/null @@ -1,16 +0,0 @@ - ['pipe', 'r'], 1 => ['pipe', 'w'], 2 => ['pipe', 'w']]; - $env = $_ENV; - LlvmToolchain::applyProcessEnv($env, $repo); - $proc = proc_open(['php', $repo.'/bin/vm.php', $path], $descriptor, $pipes, $repo, $env); - $this->assertIsResource($proc); - fclose($pipes[0]); - $stderr = stream_get_contents($pipes[2]); - fclose($pipes[2]); - $out = stream_get_contents($pipes[1]); - fclose($pipes[1]); - $this->assertSame(0, proc_close($proc)); - $this->assertStringContainsString('ok', trim((string) $stderr)."\n".(string) $out); + $code = <<<'PHP' +$dt = DateTime::createFromFormat('Y-m-d', '2020-02-30'); +if (false === $dt) { + fwrite(STDERR, "createFromFormat failed\n"); + exit(1); +} +if ('2020-03-01' !== $dt->format('Y-m-d')) { + fwrite(STDERR, 'date rollover mismatch: '.$dt->format('Y-m-d')."\n"); + exit(1); +} +if ($dt->format('H:i:s') !== date('H:i:s')) { + fwrite(STDERR, 'time default mismatch: '.$dt->format('H:i:s').' vs '.date('H:i:s')."\n"); + exit(1); +} +$partial = DateTime::createFromFormat('Y-m-d H', '2020-01-01 14'); +if ('14:00:00' !== $partial->format('H:i:s')) { + fwrite(STDERR, 'partial time mismatch: '.$partial->format('H:i:s')."\n"); + exit(1); +} +echo "ok\n"; +PHP; + $out = $this->runBin('bin/vm.php', $code); + $this->assertStringContainsString('ok', $out); } private function runBin(string $bin, string $code): string