From 77f369e3da00c4212954c1abdf6d322e11e2a567 Mon Sep 17 00:00:00 2001 From: Ryan Ghods Date: Sat, 22 Aug 2026 16:12:02 -0700 Subject: [PATCH] fix(ci): stop pinning submodules to tags via `branch` `.gitmodules` declared `branch = v1.5.0` for lib/forge-std and `branch = v0.1.3` for lib/create2-helpers. Both values are tags, not branches. With no foundry.lock committed, `forge install` treats every submodule as out of sync and checks it out at its recorded identifier; a `branch` line makes that identifier the literal string, so forge runs `git checkout v1.5.0` against the depth-1 submodule clone that actions/checkout produces, which carries no tags. Every Forge job died there before compiling anything. Dropping both lines leaves the recorded commits as the only pin, which is what the repo already built against. All ten resolved gitlinks are unchanged. Also pin foundry-toolchain to v1.5.1 rather than tracking nightly, since toolchain drift is what broke the step. Co-Authored-By: Claude Opus 5 --- .github/workflows/test.yml | 4 ++-- .gitmodules | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b4ad5be8..c48e19db 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -102,7 +102,7 @@ jobs: - name: Install Foundry uses: foundry-rs/foundry-toolchain@v1 with: - version: nightly + version: v1.5.1 - name: Install forge dependencies run: forge install @@ -124,7 +124,7 @@ jobs: - name: Install Foundry uses: foundry-rs/foundry-toolchain@v1 with: - version: nightly + version: v1.5.1 - name: Install forge dependencies run: forge install diff --git a/.gitmodules b/.gitmodules index 50a2dacd..0601fc1d 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,7 +1,6 @@ [submodule "lib/forge-std"] path = lib/forge-std url = https://github.com/foundry-rs/forge-std - branch = v1.5.0 [submodule "lib/ERC721A"] path = lib/ERC721A url = https://github.com/chiru-labs/ERC721A @@ -29,4 +28,3 @@ [submodule "lib/create2-helpers"] path = lib/create2-helpers url = https://github.com/emo-eth/create2-helpers - branch = v0.1.3