diff --git a/spec/System/TestSkills_spec.lua b/spec/System/TestSkills_spec.lua index 9c756768e..ec9a3ac2b 100644 --- a/spec/System/TestSkills_spec.lua +++ b/spec/System/TestSkills_spec.lua @@ -426,4 +426,29 @@ describe("TestSkills", function() runCallback("OnFrame") assert.True(build.calcsTab.mainOutput.TotalDPS > iceShotDPS) end) + + it("Test Minion Pact damage requires a minion in your presence", function() + build.itemsTab:CreateDisplayItemFromRaw([[ + New Item + Warmonger Bow + Quality: 0 + ]]) + build.itemsTab:AddDisplayItem() + runCallback("OnFrame") + + build.skillsTab:PasteSocketGroup("Lightning Arrow 1/0 1\nMinion Pact I 1/0 1") + runCallback("OnFrame") + + local activeSkill = build.calcsTab.calcsEnv.player.activeSkillList[1] + assert.are.equals(0, activeSkill.skillModList:Sum("MORE", activeSkill.skillCfg, "Damage")) + local noMinionDps = build.calcsTab.calcsOutput.TotalDPS + + build.configTab.input.multiplierMinionsInPresence = 1 + build.configTab:BuildModList() + runCallback("OnFrame") + + activeSkill = build.calcsTab.calcsEnv.player.activeSkillList[1] + assert.are.equals(30, activeSkill.skillModList:Sum("MORE", activeSkill.skillCfg, "Damage")) + assert.True(build.calcsTab.calcsOutput.TotalDPS > noMinionDps) + end) end) diff --git a/src/Data/Skills/sup_int.lua b/src/Data/Skills/sup_int.lua index 4a592a049..eef50f101 100644 --- a/src/Data/Skills/sup_int.lua +++ b/src/Data/Skills/sup_int.lua @@ -6106,7 +6106,7 @@ skills["SupportMinionPactPlayer"] = { statDescriptionScope = "gem_stat_descriptions", statMap = { ["support_minion_pact_damage_+%_final"] = { - mod("Damage", "MORE", nil), + mod("Damage", "MORE", nil, 0, 0, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }), }, }, baseFlags = { @@ -6143,7 +6143,7 @@ skills["SupportMinionPactPlayerTwo"] = { statDescriptionScope = "gem_stat_descriptions", statMap = { ["support_minion_pact_damage_+%_final"] = { - mod("Damage", "MORE", nil), + mod("Damage", "MORE", nil, 0, 0, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }), }, }, baseFlags = { diff --git a/src/Export/Skills/sup_int.txt b/src/Export/Skills/sup_int.txt index cccbf0c07..c0cbe8b59 100644 --- a/src/Export/Skills/sup_int.txt +++ b/src/Export/Skills/sup_int.txt @@ -1138,7 +1138,7 @@ statMap = { #set SupportMinionPactPlayer statMap = { ["support_minion_pact_damage_+%_final"] = { - mod("Damage", "MORE", nil), + mod("Damage", "MORE", nil, 0, 0, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }), }, }, #mods @@ -1148,7 +1148,7 @@ statMap = { #set SupportMinionPactPlayerTwo statMap = { ["support_minion_pact_damage_+%_final"] = { - mod("Damage", "MORE", nil), + mod("Damage", "MORE", nil, 0, 0, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }), }, }, #mods