Windows libopenshot builds successfully, but test errors

[xymox12]

Hi

I've created a very-much-WIP Windows build env for libopenshot that successfully builds libopenshot but reports these test failures:

25:Caption:caption effect
31:Clip:verify parent Timeline
35:Clip:time remapping
36:Clip:resample_audio_8000_to_48000_reverse
94:FrameMapper:resample_audio_48000_to_41000
95:FrameMapper:resample_audio_mapper
176:Timeline:Multi-threaded Timeline Add/Remove Clip

An example report from LastTest.log is copied further down. The full log, and notes about the build method I used including workarounds, are in my repo:

• Log: https://github.com/xymox12/libopenshot-WSB-Build-Environment/tree/main/libraries/test-logs

Any advice? (I didn't downgrade Python from the version MSYS2 installed [3.12.10] as I thought that was supported by the library now.)

Thanks

35/193 Testing: Clip:time remapping
35/193 Test: Clip:time remapping
Command: "C:/shared/libopenshot/build/tests/openshot-Clip-test.exe" "time remapping"
Directory: C:/shared/libopenshot/build/tests
"Clip:time remapping" start time: May 23 12:14 GMT Daylight Time
Output:
----------------------------------------------------------
Filters: "time remapping"
Randomness seeded to: 2108013128

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
openshot-Clip-test.exe is a Catch2 v3.8.1 host application.
Run with -? for options

-------------------------------------------------------------------------------
time remapping
-------------------------------------------------------------------------------
C:/shared/libopenshot/tests/Clip.cpp:375
...............................................................................

C:/shared/libopenshot/tests/Clip.cpp:375: FAILED:
due to unexpected exception with message:
  std::bad_array_new_length

===============================================================================
test cases: 1 | 1 failed
assertions: 1 | 1 failed

[SWR @ 0000025a79820140] Input channel layout "" is invalid or unsupported.
[SWR @ 0000025a79820140] Context has not been initialized
<end of output>
Test time =   6.40 sec
----------------------------------------------------------
Test Failed.
"Clip:time remapping" end time: May 23 12:15 GMT Daylight Time
"Clip:time remapping" time elapsed: 00:00:06
----------------------------------------------------------

[xymox12]

Related to #964 ?

[xymox12]

Ok - I retried and now have a few more errors (I believe more test have been added in recent commits). I'll attach the full log.

fails.log

The following tests FAILED:
25 - Caption:caption effect (Failed) Caption
31 - Clip:verify parent Timeline (Failed) Clip
35 - Clip:time remapping (Failed) Clip
36 - Clip:resample_audio_8000_to_48000_reverse (Failed) Clip
94 - FrameMapper:resample_audio_48000_to_41000 (Failed) FrameMapper
95 - FrameMapper:resample_audio_mapper (Failed) FrameMapper
161 - SphericalMetadata:SphericalMetadata_Test (Failed) SphericalMetadata
162 - SphericalMetadata:SphericalMetadata_FullOrientation (Failed) SphericalMetadata
179 - Timeline:Multi-threaded Timeline Add/Remove Clip (Exit code 0xc0000409
) Timeline

FYI: I had already tried building my own earlier version (6.1.1) of ffmpeg, and using the 4.4 ffmpeg libraries that MYSY2 offer but they caused their own set of problems. So I returned to using the out-the-box ffmpeg MSYS2 offers for the above build.

[dragon8609]

Hi
I referred to the code related to swr in FFmpegWriter.cpp to modify the FrameMapper.cpp file, which resolved the FFmpeg 7.0 issue. Hope this helps you.

#if HAVE_CH_LAYOUT
AVChannelLayout in_chlayout;
AVChannelLayout out_chlayout;
av_channel_layout_from_mask(&in_chlayout, channel_layout_in_frame);
av_channel_layout_from_mask(&out_chlayout, info.channel_layout);
av_opt_set_chlayout(avr, "in_chlayout", &in_chlayout, 0);
av_opt_set_chlayout(avr, "out_chlayout", &out_chlayout, 0);
#else
av_opt_set_int(avr, "in_channel_layout", channel_layout_in_frame, 0);
av_opt_set_int(avr, "out_channel_layout", info.channel_layout, 0);
av_opt_set_int(avr, "in_channels", channels_in_frame, 0);
av_opt_set_int(avr, "out_channels", info.channels, 0);
#endif
av_opt_set_int(avr, "in_sample_fmt", AV_SAMPLE_FMT_S16, 0);
av_opt_set_int(avr, "out_sample_fmt", AV_SAMPLE_FMT_S16, 0);
av_opt_set_int(avr, "in_sample_rate", sample_rate_in_frame, 0);
av_opt_set_int(avr, "out_sample_rate", info.sample_rate, 0);