fix: revert change to address sonarqube attempted fix - need iterable copy of dictionary to loop through

Author: stevenhsd

src/dve/core_engine/backends/base/rules.py

@@ -865,5 +865,5 @@ def _remove_cached_artifact(self, entity_name: EntityName):
 
     def clear_entity_cache(self):
         """Helper method to remove all artifacts and cache trackers at end of processing."""
-        for entity_name in self.entity_cache_tracker:
+        for entity_name in list(self.entity_cache_tracker):
             self._remove_cached_artifact(entity_name)

src/dve/core_engine/backends/implementations/duckdb/rules.py

@@ -594,7 +594,7 @@ def cache_entity(self, entity_name: EntityName, entities: DuckDBEntities):
         removed as part of the function (in case the newer cache depends on the older one)."""
         _tmp_name = f"{entity_name}_{uuid4().hex}"
 
-        if entity := entities.get(entity_name): # pylint: disable=W0612
+        if entity := entities.get(entity_name):  # pylint: disable=W0612
             self.connection.sql(f"CREATE OR REPLACE TEMP TABLE {_tmp_name} AS SELECT * FROM entity")
             entities[entity_name] = self.connection.table(_tmp_name)
 

src/dve/pipeline/pipeline.py

@@ -756,7 +756,7 @@ def apply_business_rules(  # pylint: disable=R0914,R0915
                 final_projection
             )
 
-        self.step_implementations.clear_entity_cache() # type: ignore
+        self.step_implementations.clear_entity_cache()  # type: ignore
 
         fh.remove_prefix(
             fh.joinuri(