fix: change processed in orphan and group rejections to work as intended

Author: georgeRobertson

src/dve/core_engine/backends/base/rules.py

@@ -397,14 +397,11 @@ def identify_and_remove_orphans(
         def process_node(
             node: HierarchyNode,
             parent_entity_name: Optional[EntityName],
-            orph_messages: Messages | None = None,
-        ):
+            processed: bool = False,
+        ) -> bool:
             """Recursive helper to process a node and its children."""
             current_entity_name = node.entity_name
 
-            if orph_messages is None:
-                orph_messages = []
-
             if parent_entity_name is not None:
                 self.logger.info(f"Identifying orphans in {current_entity_name}")
 
@@ -427,6 +424,7 @@ def process_node(
                     self.logger.info(
                         f"Removing records with missing parent from {current_entity_name}"
                     )
+                    processed = True
                     location = list(node.join_fields.values())[0]
                     with BackgroundMessageWriter(
                         working_directory=working_directory,
@@ -466,16 +464,17 @@ def process_node(
 
             if node.children:
                 for child_node in node.children:
-                    process_node(child_node, current_entity_name, orph_messages)
+                    processed = process_node(child_node, current_entity_name, processed)
+
+            return processed
 
         processed = False
 
         for root_node in entity_hierarchy.entity_trees.values():
-            process_node(root_node, parent_entity_name=None)
+            processed = process_node(root_node, parent_entity_name=None, processed=processed)
 
         _orph_rel = entities.get(ORPHANED_RECORD_ENTITY_NAME)
         if _orph_rel is not None:
-            processed = True
             del entities[ORPHANED_RECORD_ENTITY_NAME]
 
         entities.update(entities)
@@ -496,8 +495,8 @@ def identify_and_remove_missing_mandatory_groups(
         def process_node(
             node: HierarchyNode,
             parent_entity_name: Optional[EntityName],
-            processed: Optional[bool],
-        ):
+            processed: bool = False,
+        ) -> bool:
             """Recursive helper to process a node and its children."""
             current_entity_name = node.entity_name
 
@@ -548,12 +547,14 @@ def process_node(
 
             if node.children:
                 for child_node in node.children:
-                    process_node(child_node, current_entity_name, processed)
+                    processed = process_node(child_node, current_entity_name, processed)
+
+            return processed
 
         processed = False
 
         for root_node in entity_hierarchy.entity_trees.values():
-            process_node(root_node, parent_entity_name=None, processed=processed)
+            processed = process_node(root_node, parent_entity_name=None, processed=processed)
 
         entities.update(entities)