Skip to content

Fix disabled-coin stale-share cutoff regression#168

Merged
MoneroOcean merged 1 commit into
masterfrom
codex/explain-why-10-minutes-is-better-than-60
May 22, 2026
Merged

Fix disabled-coin stale-share cutoff regression#168
MoneroOcean merged 1 commit into
masterfrom
codex/explain-why-10-minutes-is-better-than-60

Conversation

@MoneroOcean
Copy link
Copy Markdown
Owner

Motivation

  • Revert a regression that increased the disabled-coin stale-template acceptance window from 10*60*1000 to 60*60*1000, which enlarged the time miners could be credited for shares against a disabled coin and therefore risked diluting PPLNS payouts.

Description

  • Restore the disabled-coin active-template cutoff in getSubmitBlockTemplate by changing the guard in lib/pool/protocol.js from 60 * 60 * 1000 back to 10 * 60 * 1000, so submissions against a disabled coin are rejected after 10 minutes.

Testing

  • Attempted to run the automated test suite with npm test --silent, but the test harness could not run in this environment due to a missing dependency (protocol-buffers), so no test failures related to this small change were observed.

Codex Task

@MoneroOcean MoneroOcean merged commit 9ff9e45 into master May 22, 2026
2 checks passed
@MoneroOcean MoneroOcean deleted the codex/explain-why-10-minutes-is-better-than-60 branch May 22, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant